Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: otel default buckets #10

Merged
merged 9 commits into from
Mar 23, 2023
Merged

feat: otel default buckets #10

merged 9 commits into from
Mar 23, 2023

Conversation

fracasula
Copy link
Collaborator

Description

Adding the ability to specify both default buckets and per-histogram buckets.

Additional changes are done in order to update to the latest OTel release.

Notion Ticket

< Notion Link >

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage: 86.11% and project coverage change: -0.25 ⚠️

Comparison is base (b9ca023) 82.30% compared to head (3ebc287) 82.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   82.30%   82.06%   -0.25%     
==========================================
  Files          33       33              
  Lines        2187     2213      +26     
==========================================
+ Hits         1800     1816      +16     
- Misses        318      327       +9     
- Partials       69       70       +1     
Impacted Files Coverage Δ
stats/otel_measurement.go 77.08% <ø> (ø)
stats/internal/otel/options.go 87.83% <66.66%> (-5.39%) ⬇️
stats/internal/otel/otel.go 89.32% <100.00%> (+0.32%) ⬆️
stats/otel.go 74.03% <100.00%> (+1.03%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage: 88.57% and project coverage change: -1.07 ⚠️

Comparison is base (b9ca023) 82.30% compared to head (e48d689) 81.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   82.30%   81.23%   -1.07%     
==========================================
  Files          33       34       +1     
  Lines        2187     2265      +78     
==========================================
+ Hits         1800     1840      +40     
- Misses        318      354      +36     
- Partials       69       71       +2     
Impacted Files Coverage Δ
stats/otel_measurement.go 77.08% <ø> (ø)
stats/testhelper/otel.go 86.36% <ø> (ø)
config/load.go 91.93% <62.50%> (-3.63%) ⬇️
stats/internal/otel/options.go 87.83% <66.66%> (-5.39%) ⬇️
stats/internal/otel/otel.go 89.32% <100.00%> (+0.32%) ⬆️
stats/options.go 77.77% <100.00%> (+27.77%) ⬆️
stats/otel.go 75.22% <100.00%> (+2.22%) ⬆️
testhelper/docker/docker.go 88.88% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fracasula fracasula marked this pull request as ready for review March 16, 2023 15:03
@fracasula fracasula merged commit ef9e011 into main Mar 23, 2023
@fracasula fracasula deleted the feat.otelBuckets branch March 23, 2023 12:05
@github-actions github-actions bot mentioned this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants