fix: restricted nil assign of dataPlaneUrl and controlPlaneUrl (#307)

rudderlabs · Apr 12, 2023 · 0e28b6f · 0e28b6f
1 parent 6c54ed7
commit 0e28b6f
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/Sources/Classes/RSConfigBuilder.m b/Sources/Classes/RSConfigBuilder.m
@@ -28,6 +28,8 @@ - (instancetype) withDataPlaneUrl: (NSString*) dataPlaneUrl {
     if (config == nil) {
         config = [[RSConfig alloc] init];
     }
+    if (dataPlaneUrl == nil)
+        return self;
 
     NSURL *url = [[NSURL alloc] initWithString:dataPlaneUrl];
     if([RSUtils isValidURL:url]) {
@@ -167,6 +169,9 @@ - (instancetype)withControlPlaneUrl:(NSString *) controlPlaneUrl {
     if (config == nil) {
         config = [[RSConfig alloc] init];
     }
+    if (controlPlaneUrl == nil)
+        return self;
+
     NSURL *url = [[NSURL alloc] initWithString:controlPlaneUrl];
     if([RSUtils isValidURL:url]) {
         config.controlPlaneUrl = [RSUtils appendSlashToUrl: url.absoluteString];