Standard naming for endPointUrl and configPlaneUrl #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnabp92
suggested changes
Apr 1, 2020
Rudder/Classes/EventRepository.m
Outdated
| @@ -289,10 +289,10 @@ - (NSString* _Nullable) __flushEventsToServer: (NSString*) payload { | |||
| dispatch_semaphore_t semaphore = dispatch_semaphore_create(0); | |||
|
|
|||
| __block NSString *responseStr = nil; | |||
| NSString *endPointUrl = [self->config.endPointUrl stringByAppendingString:@"/v1/batch"]; | |||
| [RudderLogger logDebug:[[NSString alloc] initWithFormat:@"endPointToFlush %@", endPointUrl]]; | |||
| NSString *dataPlaneUrl = [self->config.dataPlaneUrl stringByAppendingString:@"/v1/batch"]; | |||
There was a problem hiding this comment.
dataPlaneEndPoint seems more readable
Rudder/Classes/RudderConfig.m
Outdated
| @@ -15,41 +15,41 @@ - (instancetype)init | |||
| { | |||
| self = [super init]; | |||
| if (self) { | |||
| _endPointUrl = RudderBaseUrl; | |||
| _dataPlaneUrl = RudderBaseUrl; | |||
There was a problem hiding this comment.
Can we change the name RudderBaseUrl to RudderDataPlaneUrl for better readability. Needs change in Constants.m file as well
| @@ -154,7 +154,7 @@ - (NSString *)_networkRequest { | |||
| dispatch_semaphore_t semaphore = dispatch_semaphore_create(0); | |||
|
|
|||
| __block NSString *responseStr = nil; | |||
| NSString *configUrl = [NSString stringWithFormat:@"%@/sourceConfig", _rudderConfig.configPlaneUrl]; | |||
| NSString *configUrl = [NSString stringWithFormat:@"%@/sourceConfig", _rudderConfig.controlPlaneUrl]; | |||
arnabp92
approved these changes
Apr 1, 2020
arnabp92
changed the title
pallabmaiti
pushed a commit
that referenced
this pull request
Oct 28, 2021
* renamed endPointUrl and configPlaneUrl to dataPlaneUrl and controlPlaneUrl * added deprecated functions withEndPointUrl and withConfigPlaneUrl * minor change * refactored code * Update Constants.m Co-authored-by: Arnab <arnab@rudderlabs.com>
This was referenced Feb 28, 2023
This was referenced Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is