-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standard naming for endPointUrl and configPlaneUrl #16
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
32dab22
renamed endPointUrl and configPlaneUrl to dataPlaneUrl and controlPla…
dhawal-rudder 7c62512
added deprecated functions withEndPointUrl and withConfigPlaneUrl
dhawal-rudder 82f5c29
minor change
dhawal-rudder 57ba811
refactored code
dhawal-rudder d59734f
Update Constants.m
arnabp92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,41 +15,41 @@ - (instancetype)init | |
{ | ||
self = [super init]; | ||
if (self) { | ||
_endPointUrl = RudderBaseUrl; | ||
_dataPlaneUrl = RudderBaseUrl; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we change the name RudderBaseUrl to RudderDataPlaneUrl for better readability. Needs change in |
||
_flushQueueSize = RudderFlushQueueSize; | ||
_dbCountThreshold = RudderDBCountThreshold; | ||
_sleepTimeout = RudderSleepTimeout; | ||
_logLevel = RudderLogLevelError; | ||
_configRefreshInterval = RudderConfigRefreshInterval; | ||
_trackLifecycleEvents = RudderTrackLifeCycleEvents; | ||
_recordScreenViews = RudderRecordScreenViews; | ||
_configPlaneUrl = RudderConfigPlaneUrl; | ||
_controlPlaneUrl = RudderControlPlaneUrl; | ||
_factories = [[NSMutableArray alloc] init]; | ||
} | ||
return self; | ||
} | ||
|
||
- (instancetype)init:(NSString *) endPointUrl | ||
- (instancetype)init:(NSString *) dataPlaneUrl | ||
flushQueueSize: (int) flushQueueSize | ||
dbCountThreshold: (int) dbCountThreshold | ||
sleepTimeOut: (int) sleepTimeout | ||
logLevel: (int) logLevel | ||
configRefreshInterval: (int) configRefreshInteval | ||
trackLifecycleEvents: (BOOL) trackLifecycleEvents | ||
recordScreenViews: (BOOL) recordScreenViews | ||
configPlaneUrl: (NSString *) configPlaneUrl | ||
controlPlaneUrl: (NSString *) controlPlaneUrl | ||
{ | ||
self = [super init]; | ||
if (self) { | ||
_endPointUrl = endPointUrl; | ||
_dataPlaneUrl = dataPlaneUrl; | ||
_flushQueueSize = flushQueueSize; | ||
_dbCountThreshold = dbCountThreshold; | ||
_sleepTimeout = sleepTimeout; | ||
_logLevel = logLevel; | ||
_configRefreshInterval = configRefreshInteval; | ||
_trackLifecycleEvents = trackLifecycleEvents; | ||
_recordScreenViews = recordScreenViews; | ||
_configPlaneUrl = configPlaneUrl; | ||
_controlPlaneUrl = controlPlaneUrl; | ||
_factories = [[NSMutableArray alloc] init]; | ||
} | ||
return self; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -154,7 +154,7 @@ - (NSString *)_networkRequest { | |
dispatch_semaphore_t semaphore = dispatch_semaphore_create(0); | ||
|
||
__block NSString *responseStr = nil; | ||
NSString *configUrl = [NSString stringWithFormat:@"%@/sourceConfig", _rudderConfig.configPlaneUrl]; | ||
NSString *configUrl = [NSString stringWithFormat:@"%@/sourceConfig", _rudderConfig.controlPlaneUrl]; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
[RudderLogger logDebug:[[NSString alloc] initWithFormat:@"configUrl: %@", configUrl]]; | ||
NSMutableURLRequest *urlRequest = [[NSMutableURLRequest alloc] initWithURL:[[NSURL alloc] initWithString:configUrl]]; | ||
NSData *authData = [[[NSString alloc] initWithFormat:@"%@:", _writeKey] dataUsingEncoding:NSUTF8StringEncoding]; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dataPlaneEndPoint seems more readable