Skip to content

Commit

Permalink
changed name of page event
Browse files Browse the repository at this point in the history
  • Loading branch information
prabrisha-rudder authored and sayan-rudder committed Feb 17, 2020
1 parent 2cd5a83 commit 740fe9c
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 2 deletions.
13 changes: 12 additions & 1 deletion dist/browser.js
Original file line number Diff line number Diff line change
Expand Up @@ -1199,7 +1199,18 @@ var rudderanalytics = (function (exports) {
key: "page",
value: function page(rudderElement) {
logger.debug("in Keen page");
var name = rudderElement.message.name ? rudderElement.message.name : "Loaded a Page";
var pageName = rudderElement.message.name;
var pageCategory = rudderElement.message.properties ? rudderElement.message.properties.category : undefined;
var name = "Loaded a Page";

if (pageName) {
name = "Viewed " + pageName + " page";
}

if (pageCategory && pageName) {
name = "Viewed " + pageCategory + " " + pageName + " page";
}

var properties = rudderElement.message.properties;
properties = this.getAddOn(properties);
this.client.recordEvent(name, properties);
Expand Down
4 changes: 4 additions & 0 deletions dist/rudder.min.js

Large diffs are not rendered by default.

11 changes: 10 additions & 1 deletion integrations/Keen/browser.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,16 @@ class Keen {

page(rudderElement) {
logger.debug("in Keen page");
var name = rudderElement.message.name ? rudderElement.message.name : "Loaded a Page"
const pageName = rudderElement.message.name;
const pageCategory = rudderElement.message.properties ? rudderElement.message.properties.category : undefined;
var name = "Loaded a Page"
if (pageName) {
name = "Viewed " + pageName + " page";
}
if (pageCategory && pageName) {
name = "Viewed " + pageCategory + " " + pageName + " page";
}

var properties = rudderElement.message.properties
properties = this.getAddOn(properties)
this.client.recordEvent(name, properties)
Expand Down

0 comments on commit 740fe9c

Please sign in to comment.