changes

rudderlabs · Feb 20, 2020 · b049b83 · b049b83
1 parent 759ae9a
commit b049b83
Show file tree

Hide file tree

Showing 3 changed files with 214 additions and 181 deletions.
diff --git a/analytics.js b/analytics.js
@@ -332,6 +332,8 @@ class Analytics {
    */
   group(groupId, traits, options, callback) {
 
+    if (!arguments.length) return;
+
     if (typeof options == "function") (callback = options), (options = null);
     if (typeof traits == "function") (callback = traits), (options = null), (traits = null);
     if (typeof groupId == "object") (options = traits), (traits = groupId), (groupId = this.groupId);
@@ -344,8 +346,10 @@ class Analytics {
       for (let key in traits) {
         this.groupTraits[key] = traits[key];
       }
-      this.storage.setGroupTraits(this.groupTraits);
+    } else {
+      this.groupTraits = {}
     }
+    this.storage.setGroupTraits(this.groupTraits);
 
     this.processAndSendDataToDestinations(
       "group",