change in error handling

rudderlabs · Nov 22, 2019 · d208b33 · d208b33
1 parent 72dfece
commit d208b33
Showing 1 changed file with 27 additions and 23 deletions.
diff --git a/rudder-client-javascript/analytics/utils/EventRepository.js b/rudder-client-javascript/analytics/utils/EventRepository.js
@@ -160,30 +160,34 @@ class EventRepository {
       }
       xhr.timeout = timeout;
       xhr.ontimeout = queueFn;
-
+      xhr.onerror = queueFn;
       xhr.onreadystatechange = function() {
-        if (xhr.readyState === 4 && xhr.status === 200) {
-          logger.debug("====== request processed successfully: " + xhr.status);
-          queueFn(null, xhr.status);
-        } else if (xhr.readyState === 4 && xhr.status !== 200) {
-          handleError(
-            new Error(
-              "request failed with status: " +
-                xhr.status +
-                xhr.statusText +
-                " for url: " +
-                url
-            )
-          );
-          queueFn(
-            new Error(
-              "request failed with status: " +
-                xhr.status +
-                xhr.statusText +
-                " for url: " +
-                url
-            )
-          );
+        if (xhr.readyState === 4) {
+          if (xhr.status === 429 || (xhr.status >= 500 && xhr.status < 600)) {
+            handleError(
+              new Error(
+                "request failed with status: " +
+                  xhr.status +
+                  xhr.statusText +
+                  " for url: " +
+                  url
+              )
+            );
+            queueFn(
+              new Error(
+                "request failed with status: " +
+                  xhr.status +
+                  xhr.statusText +
+                  " for url: " +
+                  url
+              )
+            );
+          } else {
+            logger.debug(
+              "====== request processed successfully: " + xhr.status
+            );
+            queueFn(null, xhr.status);
+          }
         }
       };