Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lemnisk): add rudder message identifier flag #1198

Merged
merged 10 commits into from Jul 21, 2023
Merged

fix(lemnisk): add rudder message identifier flag #1198

merged 10 commits into from Jul 21, 2023

Conversation

praveendsviz
Copy link
Contributor

@praveendsviz praveendsviz commented Jul 5, 2023 •
edited

PR Description

There are customers who have rudderstack based implementation of Lemnisk and native implementation of Lemnisk. We are adding a flag to understand the rudderstack based calls.

Notion ticket

Ticket link

Screenshots

Not a UI change

  • Chrome
  • Firefox
  • Safari

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Needed to add a flag to differentiate calls coming from Rudderstack v…
3fc2614 
…s natively on the same web page of customers
shrouti1507
shrouti1507 previously requested changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@shrouti1507 shrouti1507 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update the test cases

@shrouti1507 shrouti1507 mentioned this pull request Jul 11, 2023
Closed
1 task
@MoumitaM
Copy link
Contributor

Hi @praveendsviz, Can you please sign the CLA so that we can go ahead with your changes?

@MoumitaM MoumitaM changed the title Adding a flag to differentiate calls coming from Rudderstack vs native calls fix(lemnisk): add rudder message identifier flag to differentiate calls coming from Rudderstack vs native calls Jul 21, 2023
@MoumitaM MoumitaM changed the title fix(lemnisk): add rudder message identifier flag to differentiate calls coming from Rudderstack vs native calls fix(lemnisk): add rudder message identifier flag to differentiate calls coming from rudderstack vs native calls Jul 21, 2023
@MoumitaM MoumitaM dismissed shrouti1507’s stale review July 21, 2023 07:13

Comment is addressed

@MoumitaM MoumitaM changed the title fix(lemnisk): add rudder message identifier flag to differentiate calls coming from rudderstack vs native calls fix(lemnisk): add rudder message identifier flag Jul 21, 2023
@MoumitaM MoumitaM merged commit 37697f1 into rudderlabs:production-staging Jul 21, 2023
9 of 12 checks passed
@github-actions github-actions bot deleted the lemnisk-update-rudderstack-flag branch September 24, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koladilip koladilip koladilip approved these changes

@ItsSudip ItsSudip Awaiting requested review from ItsSudip ItsSudip is a code owner

@sandeepdsvs sandeepdsvs Awaiting requested review from sandeepdsvs sandeepdsvs is a code owner

@MoumitaM MoumitaM Awaiting requested review from MoumitaM MoumitaM is a code owner

@bardisg bardisg Awaiting requested review from bardisg

@shrouti1507 shrouti1507 Awaiting requested review from shrouti1507 shrouti1507 is a code owner

Assignees

@ItsSudip ItsSudip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@praveendsviz @MoumitaM @koladilip @shrouti1507 @ItsSudip