Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suffix added to identify individual integration scripts #377

Merged
merged 5 commits into from
Nov 19, 2021
Merged

Suffix added to identify individual integration scripts #377

merged 5 commits into from
Nov 19, 2021

Conversation

MoumitaM
Copy link
Contributor

@MoumitaM MoumitaM commented Nov 17, 2021 •
edited by SumanthPuram

Description of the change

Suffix added to identify individual integration scripts

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

saikumarrs
saikumarrs requested changes Nov 17, 2021
View reviewed changes
rollup.intgConfig.js Outdated Show resolved Hide resolved
analytics.js Outdated Show resolved Hide resolved
saikumarrs
saikumarrs requested changes Nov 18, 2021
View reviewed changes
analytics.js Outdated Show resolved Hide resolved
@saikumarrs saikumarrs merged commit ced1692 into perf_improvements Nov 19, 2021
@akashrpo akashrpo deleted the intg-name-suffix branch March 5, 2022 10:29
@shekhar-rudder shekhar-rudder mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikumarrs saikumarrs saikumarrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MoumitaM @saikumarrs