Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Production staging - > perf_improvements #418

Merged
merged 5 commits into from
Jan 6, 2022
Merged

Production staging - > perf_improvements #418

merged 5 commits into from
Jan 6, 2022

Conversation

MoumitaM
Copy link
Contributor

@MoumitaM MoumitaM commented Jan 6, 2022 •
edited by SumanthPuram

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

abandonned and others added 5 commits January 6, 2022 10:25
@abandonned
Bugfix Posthog : added 'persistence' field in options set in init() (#…
09bb23c 
…413)

* added persistence oin options set in init() and other formattings

* made persistence configurable

* updated variable name to enableLocalStoragePersistence
@ruchiramoitra
production-staging: fixed bug re cookieconsent
ef434de
@ruchiramoitra
production-staging: fixed bug re cookieconsent adding brackets to set…
7f9c8a3 
… of conditional operations
@MoumitaM
Updated ts declaration for beacon and consent manager feature (#417)
17c5a96 
* array of string, number,bool,obj support added in ts declaration

* declaration fixes

* integration option payload modified

* bump the version from 1.2.6 to 1.2.7

* date added as supported type

* declaration updated

* date type removed will be accepted as ISO string

* bump version from 1.2.7 to 1.2.8

* ts declaration updated

Co-authored-by: Moumita Mandal <moumita@rudderstack.com>
@saikumarrs
Fixed formatting issues
c645346
@MoumitaM
Copy link
Contributor Author

MoumitaM commented Jan 6, 2022

Production-staging has unnecessary change that will be pulled if merged to perf_improvements branch

@MoumitaM MoumitaM closed this Jan 6, 2022
@MoumitaM MoumitaM reopened this Jan 6, 2022
@saikumarrs saikumarrs merged commit 6f8368f into perf_improvements Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikumarrs saikumarrs saikumarrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MoumitaM @saikumarrs @abandonned @ruchiramoitra