Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE support related changes #449

Merged
merged 6 commits into from
Feb 10, 2022
Merged

IE support related changes #449

merged 6 commits into from
Feb 10, 2022

Conversation

MoumitaM
Copy link
Contributor

@MoumitaM MoumitaM commented Feb 10, 2022

Description of the change

  • Added logic for camelcase rather that using a NPM package.
  • Set a specific version(3.0.2) of the set-value package where Reflect feature is not being used.
  • Used the polyfill builder to build a CDN and dynamically load the package if any of the below features are missing.
  1. Array.find
  2. Array.includes
  3. Promise
  4. String.endsWith
  5. String.includes
  6. String.startsWith
  7. Object.entries

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

analytics.js Outdated Show resolved Hide resolved
analytics.js Outdated Show resolved Hide resolved
analytics.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@saikumarrs saikumarrs merged commit 52e695e into production-staging Feb 10, 2022
@saikumarrs saikumarrs deleted the fix/IE branch February 10, 2022 15:47
saikumarrs pushed a commit that referenced this pull request Feb 11, 2022
* IE support related changes

* logger.debug removed

* code cleanup

* set-value package replaced with simple logic

* polyfill url added in constant

* test case for camelcase logic

Co-authored-by: Moumita Mandal <moumita@rudderstack.com>

Co-authored-by: Moumita Mandal <moumita@rudderstack.com>
@saikumarrs saikumarrs linked an issue Feb 11, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not compatible with IE11
2 participants