Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VWO: added load-integration flag, logger cleanup #463

Merged
merged 3 commits into from
Feb 21, 2022
Merged

VWO: added load-integration flag, logger cleanup #463

merged 3 commits into from
Feb 21, 2022

Conversation

yashasvibajpai
Copy link
Contributor

@yashasvibajpai yashasvibajpai commented Feb 17, 2022 •
edited

Description of the change

added load-integration flag, logger cleanup

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@yashasvibajpai yashasvibajpai added the enhancement New feature or request label Feb 17, 2022
@yashasvibajpai yashasvibajpai self-assigned this Feb 17, 2022
MoumitaM
MoumitaM previously approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@MoumitaM MoumitaM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utsabc
Copy link
Member

utsabc commented Feb 18, 2022 •
edited

@yashasvibajpai did we do QA as well for E2E? If not lets do once to be sure

@utsabc utsabc merged commit 652d26c into production-staging Feb 21, 2022
@utsabc utsabc deleted the vwo-load-integration-flag branch February 21, 2022 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikumarrs saikumarrs saikumarrs left review comments

@utsabc utsabc utsabc approved these changes

@akashrpo akashrpo akashrpo approved these changes

@MoumitaM MoumitaM MoumitaM left review comments

@ItsSudip ItsSudip Awaiting requested review from ItsSudip

Assignees

@yashasvibajpai yashasvibajpai

Labels
enhancement New feature or request wip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yashasvibajpai @utsabc @MoumitaM @akashrpo @saikumarrs