Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snap Pixelfeature (enhancements): #496

Merged
merged 10 commits into from
Apr 19, 2022
Merged

Snap Pixelfeature (enhancements): #496

merged 10 commits into from
Apr 19, 2022

Conversation

ujjwal-ab
Copy link
Contributor

@ujjwal-ab ujjwal-ab commented Apr 13, 2022 •
edited by SumanthPuram

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@saikumarrs saikumarrs requested a review from utsabc April 13, 2022 11:46
@ujjwal-ab ujjwal-ab requested a review from akashrpo April 13, 2022 11:46
@ujjwal-ab ujjwal-ab self-assigned this Apr 13, 2022
saikumarrs
saikumarrs requested changes Apr 13, 2022
View reviewed changes
integrations/SnapPixel/util.js Outdated Show resolved Hide resolved
integrations/SnapPixel/util.js Outdated Show resolved Hide resolved
integrations/SnapPixel/util.js Outdated Show resolved Hide resolved
integrations/SnapPixel/util.js Show resolved Hide resolved
@akashrpo
Copy link
Contributor

We also need to add support for client_deduplication_id event parameters for all snap pixel standard events. Ref

saikumarrs
saikumarrs previously approved these changes Apr 14, 2022
View reviewed changes
@ujjwal-ab ujjwal-ab added the Ready for review Changes are ready to be reviewed label Apr 14, 2022
utsabc
utsabc previously approved these changes Apr 18, 2022
View reviewed changes
akashrpo
akashrpo reviewed Apr 18, 2022
View reviewed changes
integrations/SnapPixel/util.js Outdated Show resolved Hide resolved
integrations/SnapPixel/util.js Outdated Show resolved Hide resolved
akashrpo
akashrpo previously approved these changes Apr 18, 2022
View reviewed changes
@ujjwal-ab ujjwal-ab requested a review from utsabc April 18, 2022 09:32
@utsabc utsabc merged commit dd07d37 into v1-staging Apr 19, 2022
@utsabc utsabc deleted the snap-pixel-map-events branch April 19, 2022 07:56
@utsabc utsabc mentioned this pull request Apr 19, 2022
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akashrpo akashrpo akashrpo approved these changes

@saikumarrs saikumarrs saikumarrs approved these changes

@MoumitaM MoumitaM Awaiting requested review from MoumitaM MoumitaM is a code owner

@utsabc utsabc Awaiting requested review from utsabc

Assignees

@ujjwal-ab ujjwal-ab

Labels
Ready for review Changes are ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ujjwal-ab @akashrpo @utsabc @saikumarrs