Skip to content

Commit

Permalink
chore: enable failed keys by default (#2805)
Browse files Browse the repository at this point in the history
  • Loading branch information
chandumlg committed Dec 13, 2022
1 parent 49aa37f commit ba9832c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion app/apphandlers/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ func NewRsourcesService(deploymentType deployment.Type) (rsources.JobService, er
rsourcesConfig.LocalConn = misc.GetConnectionString()
rsourcesConfig.LocalHostname = config.GetString("DB.host", "localhost")
rsourcesConfig.SharedConn = config.GetString("SharedDB.dsn", "")
rsourcesConfig.SkipFailedRecordsCollection = !config.GetBool("Router.failedKeysEnabled", false)
rsourcesConfig.SkipFailedRecordsCollection = !config.GetBool("Router.failedKeysEnabled", true)

if deploymentType == deployment.MultiTenantType {
// For multitenant deployment type we shall require the existence of a SHARED_DB
Expand Down
2 changes: 1 addition & 1 deletion config/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ Router:
allowAbortedUserJobsCountForProcessing: 1
maxFailedCountForJob: 3
retryTimeWindow: 180m
failedKeysEnabled: false
failedKeysEnabled: true
saveDestinationResponseOverride: false
transformerProxy: false
transformerProxyRetryCount: 15
Expand Down
2 changes: 1 addition & 1 deletion router/router.go
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ func loadConfig() {
// sources failed keys config
config.RegisterDurationConfigVariable(48, &failedKeysExpire, true, time.Hour, "Router.failedKeysExpire")
config.RegisterDurationConfigVariable(24, &failedKeysCleanUpSleep, true, time.Hour, "Router.failedKeysCleanUpSleep")
failedKeysEnabled = config.GetBool("Router.failedKeysEnabled", false)
failedKeysEnabled = config.GetBool("Router.failedKeysEnabled", true)
}

func sendRetryStoreStats(attempt int) {
Expand Down

0 comments on commit ba9832c

Please sign in to comment.