Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(warehouse): dsiable reporting setup for slave #2037

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

cisse21
Copy link
Member

@cisse21 cisse21 commented Jun 7, 2022

Description

Reporting should only be done by Warehouse Master and should not be setup for slave

Notion Ticket

Notion Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #2037 (830bf8f) into master (e94d313) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #2037      +/-   ##
==========================================
- Coverage   31.84%   31.81%   -0.03%     
==========================================
  Files         163      163              
  Lines       33629    33630       +1     
==========================================
- Hits        10708    10700       -8     
- Misses      22300    22307       +7     
- Partials      621      623       +2     
Impacted Files Coverage Δ
warehouse/warehouse.go 3.20% <33.33%> (+0.07%) ⬆️
...ebugger/destination/eventDeliveryStatusUploader.go 90.12% <0.00%> (-3.71%) ⬇️
gateway/gateway.go 50.17% <0.00%> (-0.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e94d313...830bf8f. Read the comment docs.

@cisse21 cisse21 merged commit 983338a into master Jun 7, 2022
@cisse21 cisse21 deleted the fix.disableReportingWHSlave branch June 7, 2022 11:52
This was referenced Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants