Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed the output of goRoutine count from the HTTP GET / of the server #2079

Merged
merged 3 commits into from
Jun 22, 2022

Conversation

Kannaj
Copy link
Contributor

@Kannaj Kannaj commented Jun 20, 2022

When we call HTTP GET / for the rudder server - we get the below output

{"appType": "EMBEDDED", "server":"UP", "db":"UP","acceptingEvents":"TRUE","routingEvents":"TRUE","mode":"NORMAL","goroutines":"636", "backendConfigMode": "API", "lastSync":"2022-06-18T14:58:11Z", "lastRegulationSync":""}

Exposing values such as goroutines might be helpful information for harmful agents. This PR removes it from being shown by the server.

@cisse21
Copy link
Member

cisse21 commented Jun 21, 2022

@Kannaj Thanks for the PR, Can you sign this https://github.com/rudderlabs/rudder-server/blob/master/CONTRIBUTING.md so that we can go ahead and merge this change

@Kannaj
Copy link
Contributor Author

Kannaj commented Jun 21, 2022

@cisse21 done

@lvrach lvrach changed the title Removed the output of goRoutine count from the HTTP GET / of the server. fix: removed the output of goRoutine count from the HTTP GET / of the server Jun 21, 2022
@lvrach
Copy link
Member

lvrach commented Jun 21, 2022

Hey @Kannaj, one more thing. Because we are following conventional commits. Can you rename your commit to much the title (it needs a fix: prefix)?

Or push another commit, empty works as well.

@Kannaj
Copy link
Contributor Author

Kannaj commented Jun 21, 2022

@lvrach - let me know if this is ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants