fix: json out of bounds in batchrouter #2465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 41.44% // Head: 36.11% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2465 +/- ##
==========================================
- Coverage 41.44% 36.11% -5.33%
==========================================
Files 175 200 +25
Lines 36288 39662 +3374
==========================================
- Hits 15039 14324 -715
- Misses 20313 24435 +4122
+ Partials 936 903 -33
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
lvrach
force-pushed
the
fix/json-out-of-bounds
branch
from
638e52e
to
6b8d5f8
Compare
fracasula
approved these changes
Sep 26, 2022
fracasula
reviewed
Sep 26, 2022
lvrach
commented
Sep 26, 2022
saurav-malani
approved these changes
Sep 26, 2022
atzoum
reviewed
Oct 3, 2022
Co-authored-by: Francesco Casula <fracasula@users.noreply.github.com>
fracasula
force-pushed
the
fix/json-out-of-bounds
branch
from
2250548
to
4665a90
Compare
chandumlg
reviewed
Oct 3, 2022
atzoum
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We started to observe panics in the following line after we migrated to jsoniter library
err = json.Unmarshal(job.Parameters, ¶meters)I reproduced the panic by modifying the slice capacity whilst parsing it. Unfortunately, that was not enough to prove or to help find the root cause of the problem.
As a mitigation step and to increase observability, I have introduced a wrapper, that in case of panic, prints useful information and fallbacks to the standard JSON library
Notion Ticket
https://www.notion.so/rudderstacks/Batch-router-unmarshaling-slice-bounds-out-of-range-8294d65d8f014c13904980d2c6c34713
Security