chore: introduce region in reporting url #2832
Conversation
Codecov ReportBase: 47.32% // Head: 47.35% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2832 +/- ##
==========================================
+ Coverage 47.32% 47.35% +0.03%
==========================================
Files 308 308
Lines 49616 49614 -2
==========================================
+ Hits 23480 23495 +15
+ Misses 24690 24677 -13
+ Partials 1446 1442 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
cisse21
force-pushed
the
chore.introduceRegion
branch
2 times, most recently
from
ac858e3
to
00b88fb
Compare
cisse21
force-pushed
the
chore.introduceRegion
branch
from
00b88fb
to
32f65b3
Compare
cisse21
force-pushed
the
chore.introduceRegion
branch
from
2106e20
to
e0f69a8
Compare
| } | ||
| } | ||
|
|
||
| func (handle *HandleT) setup(beConfigHandle backendconfig.BackendConfig) { |
There was a problem hiding this comment.
if you are renaming r, won't it be better to rename it to h instead of handle? Since, such a large receiver name is avoided in golang.
There was a problem hiding this comment.
Used r to just represent reporting handle... can change it to rh though
| q := req.URL.Query() | ||
| q.Add("region", uploader.region) | ||
| req.URL.RawQuery = q.Encode() | ||
| } |
There was a problem hiding this comment.
[Minor] Can we write test for this?
Description
As part of data residency adaptations ... introducing the changes for encoding region into query params for reporting and live events url
Notion Ticket
Notion Link
Security