Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop column only if exists #2979

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Conversation

cisse21
Copy link
Member

@cisse21 cisse21 commented Feb 15, 2023

Description

Drop Column only if it exists in reports migration

Notion Ticket

https://www.notion.so/rudderstacks/8aac9087df644365acdf64e28e290153?v=6e06b0a5ade24f0aa5ffe05dc2972e84&p=94f69f8b3ab84461adf0aab881da2cde&pm=s

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Base: 52.20% // Head: 52.21% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (47dad38) compared to base (d1d2338).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2979   +/-   ##
=======================================
  Coverage   52.20%   52.21%           
=======================================
  Files         328      328           
  Lines       51468    51468           
=======================================
+ Hits        26870    26872    +2     
  Misses      22978    22978           
+ Partials     1620     1618    -2     
Impacted Files Coverage Δ
...rvices/streammanager/kafka/client/testutil/util.go 66.99% <0.00%> (-3.89%) ⬇️
router/router.go 76.71% <0.00%> (-0.19%) ⬇️
jobsdb/migration.go 77.06% <0.00%> (+0.77%) ⬆️
config/backend-config/namespace_config.go 70.00% <0.00%> (+3.00%) ⬆️
router/manager/manager.go 100.00% <0.00%> (+3.29%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants