Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): wrong job order keys used in batching job order logic #3019

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Feb 21, 2023

Description

The destinationID was not taken into consideration in router's job ordering logic when doing batching, which caused invalid state to be captured in barriers.

Notion Ticket

Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@atzoum atzoum merged commit e9314cf into release/1.6.x Feb 21, 2023
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release/1.6.x@1dbe505). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##             release/1.6.x    #3019   +/-   ##
================================================
  Coverage                 ?   52.84%           
================================================
  Files                    ?      338           
  Lines                    ?    52127           
  Branches                 ?        0           
================================================
  Hits                     ?    27546           
  Misses                   ?    22970           
  Partials                 ?     1611           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@atzoum atzoum deleted the fix.routerJobOrderKey branch February 21, 2023 16:06
@atzoum atzoum restored the fix.routerJobOrderKey branch February 21, 2023 16:06
@atzoum atzoum deleted the fix.routerJobOrderKey branch February 21, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants