Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: payload limiter gauge reports invalid value type #3048

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

Sidddddarth
Copy link
Member

@Sidddddarth Sidddddarth commented Feb 28, 2023

Description

Using proper numeric values (non-custom types) for limiter stats. Fixes #3046

Notion Ticket

ref github issue

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@Sidddddarth Sidddddarth changed the base branch from master to release/1.6.x February 28, 2023 09:49
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.84 ⚠️

Comparison is base (9712cf9) 53.72% compared to head (2917caf) 52.89%.

Additional details and impacted files
@@                Coverage Diff                @@
##           release/1.6.x    #3048      +/-   ##
=================================================
- Coverage          53.72%   52.89%   -0.84%     
=================================================
  Files                338      338              
  Lines              54599    52131    -2468     
=================================================
- Hits               29336    27575    -1761     
+ Misses             23587    22953     -634     
+ Partials            1676     1603      -73     
Impacted Files Coverage Δ
utils/payload/limiter_setup.go 87.27% <100.00%> (+3.18%) ⬆️
regulation-worker/internal/delete/batch/batch.go 50.56% <0.00%> (-7.93%) ⬇️
jobsdb/unionQuery.go 84.13% <0.00%> (-7.03%) ⬇️
router/router.go 78.08% <0.00%> (-6.85%) ⬇️
gateway/gateway.go 76.30% <0.00%> (-6.43%) ⬇️
warehouse/integrations/postgres/postgres.go 26.18% <0.00%> (-5.62%) ⬇️
processor/transformer/transformer.go 74.00% <0.00%> (-5.41%) ⬇️
jobsdb/jobsdb.go 73.91% <0.00%> (-5.40%) ⬇️
regulation-worker/internal/service/service.go 73.07% <0.00%> (-5.26%) ⬇️
utils/misc/misc.go 50.05% <0.00%> (-4.90%) ⬇️
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Co-authored-by: Aris Tzoumas <atzoumas@rudderstack.com>
@atzoum atzoum changed the title fix: payload limiter gauge floats fix: payload limiter gauge reports invalid value type Feb 28, 2023
@atzoum atzoum merged commit 5605abc into release/1.6.x Feb 28, 2023
@atzoum atzoum deleted the fix.payloadLimiterGaugeFloats branch February 28, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants