-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: payload limiter gauge reports invalid value type #3048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atzoum
reviewed
Feb 28, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release/1.6.x #3048 +/- ##
=================================================
- Coverage 53.72% 52.89% -0.84%
=================================================
Files 338 338
Lines 54599 52131 -2468
=================================================
- Hits 29336 27575 -1761
+ Misses 23587 22953 -634
+ Partials 1676 1603 -73
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sidddddarth
force-pushed
the
fix.payloadLimiterGaugeFloats
branch
from
February 28, 2023 11:32
b4ec5f4
to
a79ac56
Compare
atzoum
reviewed
Feb 28, 2023
Co-authored-by: Aris Tzoumas <atzoumas@rudderstack.com>
atzoum
approved these changes
Feb 28, 2023
atzoum
changed the title
fix: payload limiter gauge floats
fix: payload limiter gauge reports invalid value type
Feb 28, 2023
Merged
1 task
This was referenced Mar 6, 2023
This was referenced Mar 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using proper numeric values (non-custom types) for limiter stats. Fixes #3046
Notion Ticket
ref github issue
Security