chore: perform rss/wss-aware cgroups memory usage calculation #3052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atzoum
force-pushed
the
chore.cgroupsMemfix
branch
from
b9e3312
to
50dc9bf
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3052 +/- ##
==========================================
+ Coverage 52.68% 53.11% +0.43%
==========================================
Files 334 332 -2
Lines 52206 52350 +144
==========================================
+ Hits 27505 27806 +301
+ Misses 23110 22946 -164
- Partials 1591 1598 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
atzoum
force-pushed
the
chore.cgroupsMemfix
branch
3 times, most recently
from
22392eb
to
1c32bd1
Compare
fracasula
approved these changes
Mar 1, 2023
cisse21
approved these changes
Mar 2, 2023
atzoum
force-pushed
the
chore.cgroupsMemfix
branch
from
1c32bd1
to
0a97ada
Compare
This was referenced Mar 6, 2023
This was referenced Mar 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previous calculation of memory usage under cgroups was not taking into consideration RSS & WSS memory, it was relying only to
memory.usage_in_byteswhich can be imprecise under circumstances. This article explains how k8s actually calculates RSS & WSS memory respectively.With this change, we are now calculating both RSS & WSS values and consider the greatest one to be equal to the actual memory usage.
Note: verified in
prousmtenvironment where this inconsistency was initially observed.Notion Ticket
Link
Security