-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: avoid querying a dataset in case AfterJobID falls after said dataset #3478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atzoum
reviewed
Jun 13, 2023
Sidddddarth
force-pushed
the
chore.jobsdbAfterJobIDAvoidQuery
branch
from
June 13, 2023 12:58
7be75b2
to
36e72ea
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3478 +/- ##
==========================================
- Coverage 68.07% 68.06% -0.01%
==========================================
Files 330 330
Lines 53577 53601 +24
==========================================
+ Hits 36473 36484 +11
- Misses 14713 14724 +11
- Partials 2391 2393 +2
☔ View full report in Codecov by Sentry. |
atzoum
reviewed
Jun 13, 2023
Sidddddarth
force-pushed
the
chore.jobsdbAfterJobIDAvoidQuery
branch
from
June 14, 2023 02:29
f47c069
to
fec3337
Compare
atzoum
approved these changes
Jun 14, 2023
cisse21
approved these changes
Jun 14, 2023
Sidddddarth
force-pushed
the
chore.jobsdbAfterJobIDAvoidQuery
branch
from
June 14, 2023 09:47
fec3337
to
d318965
Compare
atzoum
force-pushed
the
chore.jobsdbAfterJobIDAvoidQuery
branch
from
June 14, 2023 11:08
d318965
to
34c4c07
Compare
atzoum
force-pushed
the
chore.jobsdbAfterJobIDAvoidQuery
branch
from
June 14, 2023 13:04
34c4c07
to
8e9b622
Compare
Merged
This was referenced Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid querying a dataset if
params.AfterJobID != nil && *params.AfterJobID > dsRange.maxJobID
.Added said logic to
jobsdb.GetProcessed(...)
andjobsdb.GetUnprocessed(...)
Notion Ticket
update archive status
Security