fixup! chore: avoid querying a dataset in case AfterJobID falls after…

… said dataset
rudderlabs · Jun 13, 2023 · f47c069 · f47c069
1 parent 36e72ea
commit f47c069
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/jobsdb/jobsdb.go b/jobsdb/jobsdb.go
@@ -3127,7 +3127,8 @@ func (jd *HandleT) getUnprocessed(ctx context.Context, params GetQueryParamsT) (
 	}
 	for idx, ds := range dsList {
 		if params.AfterJobID != nil {
-			if idx < len(dsRangeList) {
+			if idx < len(dsRangeList) { // ranges are not stored for the last ds
+				// so the following condition cannot be applied the last ds
 				if *params.AfterJobID > dsRangeList[idx].maxJobID {
 					continue
 				}
@@ -3256,7 +3257,8 @@ func (jd *HandleT) GetProcessed(ctx context.Context, params GetQueryParamsT) (Jo
 	}
 	for idx, ds := range dsList {
 		if params.AfterJobID != nil {
-			if idx < len(dsRangeList) {
+			if idx < len(dsRangeList) { // ranges are not stored for the last ds
+				// so the following condition cannot be applied the last ds
 				if *params.AfterJobID > dsRangeList[idx].maxJobID {
 					continue
 				}