chore: drop union query, fair pickup and multitenant handle #3521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3521 +/- ##
==========================================
+ Coverage 67.79% 67.81% +0.02%
==========================================
Files 325 327 +2
Lines 52627 53100 +473
==========================================
+ Hits 35678 36012 +334
- Misses 14603 14707 +104
- Partials 2346 2381 +35
☔ View full report in Codecov by Sentry. |
atzoum
force-pushed
the
chore.dropUnionQuery
branch
from
2c2236b
to
a5aafc6
Compare
atzoum
changed the title
atzoum
requested review from
cisse21,
Sidddddarth,
lvrach,
fracasula,
saurav-malani and
BonapartePC
fracasula
approved these changes
Jun 21, 2023
atzoum
force-pushed
the
chore.dropUnionQuery
branch
from
e97bfce
to
a0d59df
Compare
pChondros
approved these changes
Jun 21, 2023
| unprocessedAfterJobID := unprocessed.Jobs[len(unprocessed.Jobs)-1].JobID | ||
| mtoken.unprocessedAfterJobID = &unprocessedAfterJobID | ||
| } | ||
| list = append(list, unprocessed.Jobs...) |
There was a problem hiding this comment.
[question] does it make sense to move this in the previous if block? what purpose does it serve if len(unprocessed.Jobs) == 0?
| waitingAfterJobID := waiting.Jobs[len(waiting.Jobs)-1].JobID | ||
| mtoken.waitingAfterJobID = &waitingAfterJobID | ||
| } | ||
| list = append(list, waiting.Jobs...) |
There was a problem hiding this comment.
[question] does it make sense to move this in the previous if block? what purpose does it serve if len(waiting.Jobs) == 0?
There was a problem hiding this comment.
if waiting.Jobs is empty this is a no-op, so it doesn't hurt either :)
cisse21
approved these changes
Jun 22, 2023
atzoum
force-pushed
the
chore.dropUnionQuery
branch
5 times, most recently
from
a0c9e28
to
b30f881
Compare
atzoum
changed the title
atzoum
changed the title
atzoum
force-pushed
the
chore.dropUnionQuery
branch
from
b30f881
to
fd0963d
Compare
This was referenced Jun 29, 2023
Closed
Merged
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since router isolation feature is now in place, there is no longer the need for the fair pickup algorithm, i.e.
MultiTenantJobsDBandmultitenant.Stats. Therefore we are removing them with the following adaptations:MultiTenantJobsDB#GetAllJobshas been moved toJobsDB#GetToProcessand method's signature has been adapted accordingly. A future improvement shall follow which will adapt the method's current implementation and perform a single query instead of 3 separate ones.processoris now responsible for retrieving job pileup counters and populating the pending events stats during startup, what was previously done bymultitenant.StatsNotion Ticket
Link
Security