fix: ignore workspace if no backup config is found #3685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3685 +/- ##
==========================================
+ Coverage 68.05% 68.57% +0.51%
==========================================
Files 319 319
Lines 50445 50446 +1
==========================================
+ Hits 34332 34593 +261
+ Misses 13886 13634 -252
+ Partials 2227 2219 -8
☔ View full report in Codecov by Sentry. |
atzoum
approved these changes
Jul 31, 2023
| @@ -553,17 +553,16 @@ func (jd *HandleT) createTableDumps(queryFunc func(int64) string, pathFunc func( | |||
| } | |||
| preferences, err := jd.fileUploaderProvider.GetStoragePreferences(workspaceID) | |||
There was a problem hiding this comment.
I had to go through the actual implementation for understanding that the current implementation only throughs an error when there is no workspace present in settings. Using a sentinel error might be preferable here.
cisse21
approved these changes
Jul 31, 2023
cisse21
force-pushed
the
fix.IgnoreNoWorkspaceConfigInBackup
branch
3 times, most recently
from
f438af4
to
c5d00be
Compare
cisse21
force-pushed
the
fix.IgnoreNoWorkspaceConfigInBackup
branch
from
c5d00be
to
f3a5c81
Compare
cisse21
force-pushed
the
fix.IgnoreNoWorkspaceConfigInBackup
branch
from
f3a5c81
to
4f50645
Compare
This was referenced Aug 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ignore error resulting from a workspace's backup config not being found.
This is done so the backup is not stalled in such case.
Notion Ticket
linear cfd link
Security