-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ignore workspace if no backup config is found #3685
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3685 +/- ##
==========================================
+ Coverage 68.05% 68.57% +0.51%
==========================================
Files 319 319
Lines 50445 50446 +1
==========================================
+ Hits 34332 34593 +261
+ Misses 13886 13634 -252
+ Partials 2227 2219 -8
☔ View full report in Codecov by Sentry. |
@@ -553,17 +553,16 @@ func (jd *HandleT) createTableDumps(queryFunc func(int64) string, pathFunc func( | |||
} | |||
preferences, err := jd.fileUploaderProvider.GetStoragePreferences(workspaceID) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to go through the actual implementation for understanding that the current implementation only throughs an error when there is no workspace present in settings. Using a sentinel error might be preferable here.
f438af4
to
c5d00be
Compare
c5d00be
to
f3a5c81
Compare
f3a5c81
to
4f50645
Compare
Description
Ignore error resulting from a workspace's backup config not being found.
This is done so the backup is not stalled in such case.
Notion Ticket
linear cfd link
Security