chore: archiver cleanup #3726
Merged
chore: archiver cleanup #3726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3726 +/- ##
==========================================
- Coverage 68.13% 68.07% -0.06%
==========================================
Files 333 333
Lines 51462 51454 -8
==========================================
- Hits 35063 35028 -35
- Misses 14118 14140 +22
- Partials 2281 2286 +5
☔ View full report in Codecov by Sentry. |
fracasula
force-pushed
the
chore.archiverCleanup
branch
from
a5de74b
to
8683c2a
Compare
lvrach
approved these changes
Aug 9, 2023
| @@ -72,13 +72,16 @@ type Archiver struct { | |||
| } | |||
|
|
|||
| func (a *Archiver) backupRecords(ctx context.Context, args backupRecordsArgs) (backupLocation string, err error) { | |||
| a.Logger.Infof(`Starting backupRecords for uploadId: %s, sourceId: %s, destinationId: %s, tableName: %s,`, args.uploadID, args.sourceID, args.destID, args.tableName) | |||
| a.Logger.Infof("[Archiver]: Starting backupRecords for uploadId: %s, sourceId: %s, destinationId: %s, tableName: %s,", | |||
There was a problem hiding this comment.
We should use structured logging, I would avoid prefixing with archiver
| @@ -96,7 +99,9 @@ func (a *Archiver) backupRecords(ctx context.Context, args backupRecordsArgs) (b | |||
| Config: filemanagerutil.GetProviderConfigForBackupsFromEnv(ctx, config.Default), | |||
| }) | |||
| if err != nil { | |||
| err = fmt.Errorf("error in creating a file manager for:%s. Error: %w", config.GetString("JOBS_BACKUP_STORAGE_PROVIDER", "S3"), err) | |||
| err = fmt.Errorf("error in creating a file manager for:%s. Error: %w", | |||
achettyiitr
approved these changes
Aug 9, 2023
|
@lvrach I'll merge this one and address the structured logging in this file in another PR with low prio. |
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prepared statements for archiver + more DRY and cleanup.
Linear Ticket
< Linear Link >
Security