-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove Init and exported struct variables from Archiver #3735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achettyiitr
force-pushed
the
chore.archiver-init
branch
from
August 10, 2023 10:30
c1d3e8f
to
7b24270
Compare
fracasula
approved these changes
Aug 10, 2023
achettyiitr
force-pushed
the
chore.archiver-init
branch
from
August 10, 2023 11:37
7b24270
to
2765763
Compare
lvrach
approved these changes
Aug 10, 2023
achettyiitr
force-pushed
the
chore.archiver-init
branch
from
August 11, 2023 04:20
2765763
to
f1c3ac1
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3735 +/- ##
==========================================
+ Coverage 68.10% 68.14% +0.04%
==========================================
Files 333 334 +1
Lines 51454 51528 +74
==========================================
+ Hits 35043 35116 +73
+ Misses 14129 14127 -2
- Partials 2282 2285 +3
☔ View full report in Codecov by Sentry. |
Merged
1 task
1 task
Closed
This was referenced Aug 25, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
archive.Init()
archive.New(...)
to initialize.Linear Ticket
Security