Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove Init and exported struct variables from Archiver #3735

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Aug 10, 2023

Description

  • Remove archive.Init()
  • Expose archive.New(...) to initialize.
  • Remove Globals.

Linear Ticket

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

warehouse/archive/archiver.go Outdated Show resolved Hide resolved
warehouse/warehouse.go Outdated Show resolved Hide resolved
warehouse/archive/archiver.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 67.74% and project coverage change: +0.04% 🎉

Comparison is base (06477fc) 68.10% compared to head (f1c3ac1) 68.14%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3735      +/-   ##
==========================================
+ Coverage   68.10%   68.14%   +0.04%     
==========================================
  Files         333      334       +1     
  Lines       51454    51528      +74     
==========================================
+ Hits        35043    35116      +73     
+ Misses      14129    14127       -2     
- Partials     2282     2285       +3     
Files Changed Coverage Δ
runner/runner.go 69.91% <ø> (-0.13%) ⬇️
warehouse/archive/cron.go 50.00% <25.00%> (ø)
warehouse/archive/archiver.go 67.25% <66.00%> (+1.20%) ⬆️
warehouse/warehouse.go 54.53% <100.00%> (ø)

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants