Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: applying 1.12.2 hotfixes to main branch #3788

Merged
merged 3 commits into from
Aug 25, 2023
Merged

chore: applying 1.12.2 hotfixes to main branch #3788

merged 3 commits into from
Aug 25, 2023

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Aug 25, 2023 •
edited
Loading

Description

Applying 1.12.2 hotfixes to main branch

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

BEGIN_COMMIT_OVERRIDE
chore: deltalake error message length (#3766)
fix: extend sql middleware for mssql, azure_synapse and clickhouse (#3771)
END_COMMIT_OVERRIDE

atzoum
atzoum approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@atzoum atzoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't wait 3 days for synchronising patch releases to the main branch.
Forgetting to synchronise a patch release to the main branch can have detrimental effects to the next release.

@achettyiitr
Copy link
Member Author

We shouldn't wait 3 days for synchronising patch releases to the main branch. Forgetting to synchronise a patch release to the main branch can have detrimental effects to the next release.

I will be careful next time.

@achettyiitr achettyiitr merged commit 3bfc7e1 into master Aug 25, 2023
68 checks passed
@achettyiitr achettyiitr deleted the hotfix.1.12.2 branch August 25, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atzoum atzoum atzoum approved these changes

@cisse21 cisse21 cisse21 approved these changes

@lvrach lvrach Awaiting requested review from lvrach

Assignees
No one assigned
Labels
warehouse-team with tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@achettyiitr @atzoum @cisse21 @devops-github-rudderstack