-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: extend sql middleware for mssql, azure_synapse and clickhouse #3771
Conversation
21b99cc
to
0e6afb8
Compare
0e6afb8
to
5793537
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release/1.12.x #3771 +/- ##
==================================================
- Coverage 68.64% 68.15% -0.49%
==================================================
Files 337 334 -3
Lines 52467 51557 -910
==================================================
- Hits 36014 35138 -876
+ Misses 14146 14134 -12
+ Partials 2307 2285 -22
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good, although I don't understand how this would solve the code from getting stuck. Perhaps I'm missing some context so I'll have a look at the goroutine dumps you posted as well. I don't see a reason why this shouldn't be merged though so I'm approving 👍
Queries got stuck during fetch schema and delete for more than 5 hours. With timeouts, we will fail fast and retry. |
5793537
to
3d286f3
Compare
Description
Linear Ticket
Security