Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extend sql middleware for mssql, azure_synapse and clickhouse #3771

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

achettyiitr
Copy link
Member

Description

  • Extend SQL middleware to MSSQL, AZURE SYNAPSE, CLICKHOUSE

Linear Ticket

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@achettyiitr achettyiitr force-pushed the fix.extend-middleware branch 2 times, most recently from 21b99cc to 0e6afb8 Compare August 21, 2023 18:15
@achettyiitr achettyiitr changed the title chore: extend sql middleware for mssql, azure_synapse and clickhouse fix: extend sql middleware for mssql, azure_synapse and clickhouse Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 77.15% and project coverage change: -0.49% ⚠️

Comparison is base (e6892a2) 68.64% compared to head (3d286f3) 68.15%.
Report is 1 commits behind head on release/1.12.x.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/1.12.x    #3771      +/-   ##
==================================================
- Coverage           68.64%   68.15%   -0.49%     
==================================================
  Files                 337      334       -3     
  Lines               52467    51557     -910     
==================================================
- Hits                36014    35138     -876     
+ Misses              14146    14134      -12     
+ Partials             2307     2285      -22     
Files Changed Coverage Δ
...ehouse/integrations/azure-synapse/azure-synapse.go 62.95% <72.72%> (+0.37%) ⬆️
warehouse/integrations/mssql/mssql.go 64.03% <72.72%> (+0.04%) ⬆️
warehouse/integrations/clickhouse/clickhouse.go 77.25% <80.00%> (-0.58%) ⬇️
warehouse/integrations/manager/manager.go 92.85% <100.00%> (ø)

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fracasula fracasula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good, although I don't understand how this would solve the code from getting stuck. Perhaps I'm missing some context so I'll have a look at the goroutine dumps you posted as well. I don't see a reason why this shouldn't be merged though so I'm approving 👍

warehouse/integrations/azure-synapse/azure-synapse.go Outdated Show resolved Hide resolved
@achettyiitr
Copy link
Member Author

PR looks good, although I don't understand how this would solve the code from getting stuck. Perhaps I'm missing some context so I'll have a look at the goroutine dumps you posted as well. I don't see a reason why this shouldn't be merged though so I'm approving 👍

Queries got stuck during fetch schema and delete for more than 5 hours. With timeouts, we will fail fast and retry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants