Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update error processing of eloqua #3877

Merged
merged 2 commits into from
Sep 18, 2023
Merged

fix: update error processing of eloqua #3877

merged 2 commits into from
Sep 18, 2023

Conversation

ItsSudip
Copy link
Member

Description

We only showed error messages without any details of which fields failed. We are not delivering the error message on the dashboard. So with this task, we are fixing those issues.

Linear Ticket

Resolves INT-654

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@ItsSudip ItsSudip changed the title fix(eloqua): update error processing fix: update error processing of eloqua Sep 17, 2023
@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

Patch coverage: 53.84% and project coverage change: -0.01% ⚠️

Comparison is base (2c655f9) 68.82% compared to head (412b6b9) 68.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3877      +/-   ##
==========================================
- Coverage   68.82%   68.82%   -0.01%     
==========================================
  Files         351      351              
  Lines       52778    52790      +12     
==========================================
+ Hits        36327    36331       +4     
- Misses      14135    14141       +6     
- Partials     2316     2318       +2     
Files Changed Coverage Δ
router/batchrouter/handle_async.go 0.00% <0.00%> (ø)
...atchrouter/asyncdestinationmanager/eloqua/utils.go 70.76% <70.00%> (-0.23%) ⬇️

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chandumlg
Copy link
Member

@ItsSudip Please address the format issues.

@ItsSudip ItsSudip merged commit c22f22e into master Sep 18, 2023
35 checks passed
@github-actions github-actions bot deleted the fix.eloqua branch November 19, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants