Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UUID to Clickhouse table definition for zookeeper path #4060

Closed
redsquare opened this issue Oct 31, 2023 · 1 comment · Fixed by #4121
Closed

Add UUID to Clickhouse table definition for zookeeper path #4060

redsquare opened this issue Oct 31, 2023 · 1 comment · Fixed by #4121
Assignees
Labels
enhancement New feature or request WIP work in progress

Comments

@redsquare
Copy link

https://github.com/rudderlabs/rudder-server/blob/6d2db454218ac53cd87b43c21fcfbedf37758e50/warehouse/integrations/clickhouse/clickhouse.go#L796C1-L796C83

Can we create clickhouse tables with the following, this avoids syn issues after dropping the table and Rudder not being able to recreate it - see https://kb.altinity.com/engines/altinity-kb-atomic-database-engine/#q-i-cannot-reuse-zookeeper-path-after-dropping-the-table

CREATE ...
ON CLUSTER ...
ENGINE=ReplicatedMergeTree('/clickhouse/tables/{uuid}/{shard}/', '{replica}')

@gitcommitshow gitcommitshow added the enhancement New feature or request label Nov 2, 2023
@lvrach
Copy link
Member

lvrach commented Nov 2, 2023

we use this link to track the issue internally https://linear.app/rudderstack/issue/PIPE-482/improve-clickhouse-add-uuid-for-zookeeper

@gitcommitshow gitcommitshow added the WIP work in progress label Nov 3, 2023
@cisse21 cisse21 linked a pull request Nov 15, 2023 that will close this issue
1 task
@cisse21 cisse21 self-assigned this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request WIP work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants