-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: clickhouse zookeeper table metadata #4121
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4121 +/- ##
==========================================
+ Coverage 72.36% 72.56% +0.20%
==========================================
Files 382 382
Lines 55420 55420
==========================================
+ Hits 40105 40217 +112
+ Misses 12983 12884 -99
+ Partials 2332 2319 -13 ☔ View full report in Codecov by Sentry. |
cisse21
force-pushed
the
fix.clickhouseClusterMetadata
branch
from
November 15, 2023 10:11
e76b641
to
9db76f8
Compare
achettyiitr
reviewed
Nov 16, 2023
achettyiitr
approved these changes
Nov 16, 2023
lvrach
approved these changes
Nov 16, 2023
fracasula
approved these changes
Nov 16, 2023
Co-authored-by: Akash Chetty <achetty.iitr@gmail.com>
cisse21
force-pushed
the
fix.clickhouseClusterMetadata
branch
from
November 17, 2023 05:04
9e45f29
to
354ebce
Compare
yay |
This was referenced Dec 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The proposed change involves introducing a UUID to the storage path in Zookeeper in ClickHouse's cluster mode. This modification aims to address the issue where dropping and recreating a table takes 7-8 minutes for the metadata to be cleared. By adding a UUID to the storage path, the implementation ensures that such operations can be executed instantly, allowing data to be written to a different path in ZooKeeper. This enhancement improves the efficiency of table management in ClickHouse clusters.
Linear Ticket
Fixes PIPE-482
Security