Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert append vs merge #4129

Merged
merged 5 commits into from
Nov 14, 2023
Merged

Conversation

fracasula
Copy link
Collaborator

Description

Reverting to take more time to review all possible scenarios in order to maintain backwards compatibility in all cases.

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@fracasula fracasula marked this pull request as ready for review November 13, 2023 19:07
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/1.17.x@f4686aa). Click here to learn what that means.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/1.17.x    #4129   +/-   ##
=================================================
  Coverage                  ?   72.38%           
=================================================
  Files                     ?      382           
  Lines                     ?    55378           
  Branches                  ?        0           
=================================================
  Hits                      ?    40088           
  Misses                    ?    12963           
  Partials                  ?     2327           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lvrach lvrach merged commit 9c860c6 into release/1.17.x Nov 14, 2023
36 checks passed
@lvrach lvrach deleted the chore.revertAppendVsMerge branch November 14, 2023 07:20
This was referenced Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants