Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 'config' field to proxy request for v1 #4264

Merged
merged 8 commits into from
Jan 4, 2024

Conversation

Gauravudia
Copy link
Contributor

@Gauravudia Gauravudia commented Dec 28, 2023

Description

Resolves INT-1233
Update the transformer <> server proxy contract to support including 'config' at the root level in the proxy request from the server to the transformer. With these changes, the server will now append an additional 'config' field to the proxy request, propagating it to the transformer for utilization.

Linear Ticket

https://linear.app/rudderstack/issue/INT-1233/transformerproxy-propagate-destination-config-to-transformerproxy-api

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link
Contributor

coderabbitai bot commented Dec 28, 2023

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
    • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@Gauravudia Gauravudia changed the title feat: update transformer proxy contract to include new field 'config' feat: adding config in proxy request Dec 28, 2023
@Gauravudia Gauravudia changed the title feat: adding config in proxy request feat: add 'config' field to proxy request Dec 28, 2023
@Gauravudia Gauravudia self-assigned this Dec 28, 2023
@Gauravudia Gauravudia marked this pull request as ready for review December 28, 2023 09:58
@@ -65,6 +65,7 @@ type ProxyRequestMetadata struct {
type ProxyRequestPayload struct {
integrations.PostParametersT
Metadata []ProxyRequestMetadata `json:"metadata"`
Config map[string]interface{} `json:"config"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DestinationConfig would be better avoid confusion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorporated the changes.

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d078c93) 73.99% compared to head (186a5a8) 74.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4264      +/-   ##
==========================================
+ Coverage   73.99%   74.13%   +0.14%     
==========================================
  Files         388      388              
  Lines       55097    55098       +1     
==========================================
+ Hits        40769    40849      +80     
+ Misses      12004    11939      -65     
+ Partials     2324     2310      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gauravudia Gauravudia merged commit 1c3fb01 into master Jan 4, 2024
42 checks passed
@chandumlg chandumlg deleted the feat/transformerProxy-response branch January 4, 2024 12:43
This was referenced Jan 15, 2024
@Gauravudia Gauravudia changed the title feat: add 'config' field to proxy request feat: add 'config' field to proxy request for v1 Jan 25, 2024
This was referenced Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants