-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add 'config' field to proxy request for v1 #4264
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChat with CodeRabbit Bot (
|
router/transformer/transformer.go
Outdated
@@ -65,6 +65,7 @@ type ProxyRequestMetadata struct { | |||
type ProxyRequestPayload struct { | |||
integrations.PostParametersT | |||
Metadata []ProxyRequestMetadata `json:"metadata"` | |||
Config map[string]interface{} `json:"config"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DestinationConfig would be better avoid confusion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorporated the changes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4264 +/- ##
==========================================
+ Coverage 73.99% 74.13% +0.14%
==========================================
Files 388 388
Lines 55097 55098 +1
==========================================
+ Hits 40769 40849 +80
+ Misses 12004 11939 -65
+ Partials 2324 2310 -14 ☔ View full report in Codecov by Sentry. |
Description
Resolves INT-1233
Update the transformer <> server proxy contract to support including 'config' at the root level in the proxy request from the server to the transformer. With these changes, the server will now append an additional 'config' field to the proxy request, propagating it to the transformer for utilization.
Linear Ticket
https://linear.app/rudderstack/issue/INT-1233/transformerproxy-propagate-destination-config-to-transformerproxy-api
Security