Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add 'config' field to proxy request for v0 #4352

Merged
merged 5 commits into from
Feb 1, 2024
Merged

feat: add 'config' field to proxy request for v0 #4352

merged 5 commits into from
Feb 1, 2024

Conversation

Gauravudia
Copy link
Contributor

@Gauravudia Gauravudia commented Jan 25, 2024 •
edited

Description

Resolves INT-1407
Update the transformer <> server proxy contract to support including 'config' at the root level in the proxy request from the server to the transformer. With these changes, the server will now append an additional 'config' field to the proxy request, propagating it to the transformer for utilization.
In this PR enabling it for V0. For V1 it was already enabled with this PR.

Linear Ticket

https://linear.app/rudderstack/issue/INT-1407/enable-destination-config-to-v0-proxy-endpoint

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@Gauravudia Gauravudia self-assigned this Jan 25, 2024
@Gauravudia Gauravudia marked this pull request as ready for review January 25, 2024 12:35
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 25, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

chandumlg
chandumlg reviewed Jan 25, 2024
View reviewed changes
router/transformer/transformer_proxy_adapter.go
@@ -25,7 +25,8 @@ type transformerProxyAdapter interface {

type ProxyRequestPayloadV0 struct {
integrations.PostParametersT
Metadata ProxyRequestMetadata `json:"metadata"`
Metadata ProxyRequestMetadata `json:"metadata"`
DestinationConfig map[string]interface{} `json:"destinationConfig"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem like a breaking change. So, no big deal. But ideally, we should be using v1 and deprecate v0 soon.

@chandumlg chandumlg mentioned this pull request Jan 30, 2024
Merged
10 tasks
@codecov Codecov
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f5d8de3) 74.01% compared to head (3dd4ff5) 74.21%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4352      +/-   ##
==========================================
+ Coverage   74.01%   74.21%   +0.20%     
==========================================
  Files         381      381              
  Lines       54406    54407       +1     
==========================================
+ Hits        40266    40379     +113     
+ Misses      11854    11754     -100     
+ Partials     2286     2274      -12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gauravudia Gauravudia merged commit 4fdd81c into master Feb 1, 2024
42 checks passed
This was referenced Feb 9, 2024
Closed
Merged
atzoum pushed a commit that referenced this pull request Feb 12, 2024
@Gauravudia @koladilip
@achettyiitr @atzoum
feat: add 'config' field to proxy request for v0 (#4352)
09b9f71 
* feat: add 'config' field to proxy request for v0

* chore: remove logger

---------

Co-authored-by: Dilip Kola <33080863+koladilip@users.noreply.github.com>
Co-authored-by: Akash Chetty <achetty.iitr@gmail.com>
@devops-github-rudderstack devops-github-rudderstack mentioned this pull request Feb 12, 2024
Merged
@github-actions github-actions bot deleted the feat.v0-proxyRequest branch April 2, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koladilip koladilip koladilip approved these changes

@chandumlg chandumlg chandumlg approved these changes

Assignees

@Gauravudia Gauravudia

Labels
integrations-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Gauravudia @koladilip @chandumlg @achettyiitr