Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: quote table identifier #2810

Merged
merged 2 commits into from
Dec 15, 2022
Merged

Conversation

chandumlg
Copy link
Member

@chandumlg chandumlg commented Dec 14, 2022

Description

Quote table identifier. Fixes cases when table name has "-" in it.

Note: Manually tested these changes. Not writing tests, because this code is gonna be removed soon.

Notion Ticket

https://www.notion.so/rudderstacks/8aac9087df644365acdf64e28e290153?v=6e06b0a5ade24f0aa5ffe05dc2972e84&p=47af60cd5cb841769e640c3b9403c8fb&pm=s

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@chandumlg chandumlg changed the base branch from master to release/1.4.x December 14, 2022 06:53
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Base: 46.93% // Head: 46.78% // Decreases project coverage by -0.15% ⚠️

Coverage data is based on head (fe75b21) compared to base (1534d64).
Patch coverage: 30.23% of modified lines in pull request are covered.

Additional details and impacted files
@@                Coverage Diff                @@
##           release/1.4.x    #2810      +/-   ##
=================================================
- Coverage          46.93%   46.78%   -0.16%     
=================================================
  Files                301      301              
  Lines              49161    49160       -1     
=================================================
- Hits               23076    22998      -78     
- Misses             24620    24699      +79     
+ Partials            1465     1463       -2     
Impacted Files Coverage Δ
jobsdb/jobsdb.go 73.10% <ø> (-0.13%) ⬇️
jobsdb/readonly_jobsdb.go 34.26% <30.23%> (+0.05%) ⬆️
processor/stash/stash.go 44.56% <0.00%> (-22.10%) ⬇️
...rvices/streammanager/kafka/client/testutil/util.go 66.99% <0.00%> (-3.89%) ⬇️
router/manager/manager.go 96.70% <0.00%> (-3.30%) ⬇️
config/backend-config/namespace_config.go 67.00% <0.00%> (-3.00%) ⬇️
services/db/recovery.go 54.76% <0.00%> (-1.20%) ⬇️
jobsdb/backup.go 75.45% <0.00%> (-0.37%) ⬇️
router/router.go 73.68% <0.00%> (-0.19%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chandumlg chandumlg merged commit 58f2e4c into release/1.4.x Dec 15, 2022
@chandumlg chandumlg deleted the chore.quote-table-identifier branch December 15, 2022 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants