feat(warehouse): added additional datatypes for warehouse integrations #2971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2971 +/- ##
==========================================
+ Coverage 53.51% 53.59% +0.08%
==========================================
Files 350 350
Lines 54452 54452
==========================================
+ Hits 29139 29184 +45
+ Misses 23649 23612 -37
+ Partials 1664 1656 -8
... and 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
lvrach
approved these changes
Feb 14, 2023
…t.integration-additional-datatypes
achettyiitr
force-pushed
the
feat.integration-additional-datatypes
branch
from
c8f241e
to
b289470
Compare
…t.integration-additional-datatypes
|
DeepSource issues are resolved in this #2964 |
…t.integration-additional-datatypes
…t.integration-additional-datatypes
…t.integration-additional-datatypes
|
This PR is considered to be stale. It has been open 20 days with no further activity thus it is going to be closed in 5 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR. |
achettyiitr
commented
Apr 25, 2023
Comment on lines
+60
to
+96
| "bigint": "int", | ||
| "int": "int", | ||
| "smallint": "int", | ||
| "tinyint": "int", | ||
| "integer": "int", | ||
|
|
||
| "numeric": "float", | ||
| "decimal": "float", | ||
| "money": "float", | ||
| "small money": "float", | ||
| "real": "float", | ||
| "float": "float", | ||
| "double precision": "float", | ||
|
|
||
| "char": "string", | ||
| "nchar": "string", | ||
| "varchar": "string", | ||
| "nvarchar": "string", | ||
| "text": "string", | ||
| "ntext": "string", | ||
| "binary": "string", | ||
| "image": "string", | ||
| "varbinary": "string", | ||
| "uniqueidentifier": "string", | ||
|
|
||
| "date": "datetime", | ||
| "datetimeoffset": "datetime", | ||
| "datetime2": "datetime", | ||
| "smalldatetime": "datetime", | ||
| "datetime": "datetime", | ||
| "time": "datetime", | ||
| "timestamp with time zone": "datetime", | ||
| "timestamp": "datetime", | ||
| "jsonb": "json", | ||
| "bit": "boolean", | ||
|
|
||
| "bit": "boolean", | ||
|
|
||
| "jsonb": "json", |
There was a problem hiding this comment.
These datatypes we have added:
int, money, small money, uniqueidentifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
warehouse_rudder_missing_datatypestats generated during the fetching of the schema from the warehouse.Corresponding documentation links:
Notion Ticket
https://www.notion.so/rudderstacks/Additional-datatypes-for-warehouse-Integrations-a765dda055db40589f0b2eedddce56ad?pvs=4
Security