Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dedup destination metadata in router based on job id #2982

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Feb 15, 2023

Description

Workaround until transformer adaptations are ready so that we can enforce validations introduced by #2970

Notion Ticket

Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@atzoum atzoum requested a review from cisse21 February 15, 2023 13:07
@atzoum atzoum changed the title chore: dedup destination metadata based on job id chore: dedup destination metadata in router based on job id Feb 15, 2023
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Base: 52.21% // Head: 52.35% // Increases project coverage by +0.13% 🎉

Coverage data is based on head (8d03654) compared to base (03e7390).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 8d03654 differs from pull request most recent head c48a45f. Consider uploading reports for the commit c48a45f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2982      +/-   ##
==========================================
+ Coverage   52.21%   52.35%   +0.13%     
==========================================
  Files         328      328              
  Lines       51468    51472       +4     
==========================================
+ Hits        26876    26950      +74     
+ Misses      22975    22902      -73     
- Partials     1617     1620       +3     
Impacted Files Coverage Δ
router/router.go 76.95% <100.00%> (+0.24%) ⬆️
services/rsources/handler.go 74.65% <0.00%> (-0.56%) ⬇️
jobsdb/backup.go 75.76% <0.00%> (+0.35%) ⬆️
jobsdb/migration.go 78.35% <0.00%> (+2.06%) ⬆️
processor/stash/stash.go 66.66% <0.00%> (+21.61%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants