Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rudder-server modification to use suppression-backup service. #3116
feat: rudder-server modification to use suppression-backup service. #3116
Changes from all commits
baa0b41
c8b67fa
b606faf
526dbf9
f108c6a
a34da7a
544cf3c
485b9c6
9f82fbb
02690b4
948e811
aa52a3c
e16acec
41f3469
e2f073d
2888e83
bee1c28
2b3850c
878e4f9
46d13bd
01ee33b
8bf9f2e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels like it would be better to log the error in the anonymous function instead of logging it here. This way we can add some context to the error like:
Also, I'm not sure trying these ops forever without anybody looking at the logs is a good idea.
For example, let's say that it fails forever at the 2nd step (i.e.
fullSyncer.Sync(ctx)
). How are we going to notice?cc @atzoum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alerting for sync failures is something we are missing for the whole suppression feature (not just for this scenario). Let's treat alerting in another task