Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable backoff when event ordering is disabled #3121

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Mar 21, 2023

Description

Enabling backoff even when event ordering is disabled.
Additionally, increasing jobIteratorMaxQueries to 50 so that router can go deeper in jobsdb's queue in case a large number of events exist in the queue's head which are for the same userID and destination that is rate limited. By increasing the number of max queries we are effectively allowing the router to pickup jobs for other non-rate-limited users which are waiting at the tail of the queue.

Notion Ticket

Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@atzoum atzoum marked this pull request as ready for review March 21, 2023 16:30
@atzoum atzoum force-pushed the chore.backoff branch 2 times, most recently from 3310f60 to 3b786d6 Compare March 22, 2023 15:34
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (0aab933) 52.27% compared to head (882c37f) 52.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3121      +/-   ##
==========================================
+ Coverage   52.27%   52.28%   +0.01%     
==========================================
  Files         321      321              
  Lines       52765    52766       +1     
==========================================
+ Hits        27583    27591       +8     
+ Misses      23525    23521       -4     
+ Partials     1657     1654       -3     
Impacted Files Coverage Δ
router/router.go 78.14% <100.00%> (+0.27%) ⬆️

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants