-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: kafka batching #3151
chore: kafka batching #3151
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3151 +/- ##
==========================================
+ Coverage 52.28% 52.35% +0.06%
==========================================
Files 321 321
Lines 52789 52809 +20
==========================================
+ Hits 27602 27646 +44
+ Misses 23527 23512 -15
+ Partials 1660 1651 -9
... and 7 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@@ -0,0 +1,478 @@ | |||
package kafka_batching |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: does batching work in combination with AVRO Schema Lists and/or multiple topic support? This is not evident by looking here, where it seems like the process
method is performing more steps than its batch
counterpart. Maybe batch
is called with events that have already been process
ed in a previous step?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I can answer that question myself... events are first transformed at processor, then batched at router!
Description
Making sure that batching on Kafka works as expected.
Notion Ticket
< Notion Link >
Security