-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove readonlyjobsdb and some status handlers #3168
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3168 +/- ##
==========================================
+ Coverage 52.36% 53.42% +1.05%
==========================================
Files 322 315 -7
Lines 52953 51757 -1196
==========================================
- Hits 27729 27650 -79
+ Misses 23545 22438 -1107
+ Partials 1679 1669 -10
... and 9 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
do we need any adaptations in rudder cli as well? |
we do, in progress. |
if we want to discontinue with cli entirely, we could remove more things as well. |
Is this what we are removing support for? |
Yes. Not only that but everything except logging and warehouse for now. There are some warehouse related functionalities(trigger-upload and a few other). If the cli isn't used for it, we could entirely remove it. @lvrach |
In conclusion, kept the below functionalities intact:
We can remove more of these if they're unused or out of favour. |
59ea134
to
7af925e
Compare
Anyone who is using rudder-cli to comment here? |
Description
removing some unused code, functionality.
Notion Ticket
< Replace with Notion Link >
Security