Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove readonlyjobsdb and some status handlers #3168

Merged
merged 3 commits into from
Apr 7, 2023

Conversation

Sidddddarth
Copy link
Member

Description

removing some unused code, functionality.

Notion Ticket

< Replace with Notion Link >

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.05 🎉

Comparison is base (f328e43) 52.36% compared to head (59ea134) 53.42%.

❗ Current head 59ea134 differs from pull request most recent head 7af925e. Consider uploading reports for the commit 7af925e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3168      +/-   ##
==========================================
+ Coverage   52.36%   53.42%   +1.05%     
==========================================
  Files         322      315       -7     
  Lines       52953    51757    -1196     
==========================================
- Hits        27729    27650      -79     
+ Misses      23545    22438    -1107     
+ Partials     1679     1669      -10     
Impacted Files Coverage Δ
app/apphandlers/embeddedAppHandler.go 78.80% <ø> (+0.76%) ⬆️
app/apphandlers/gatewayAppHandler.go 14.44% <ø> (+0.76%) ⬆️
app/apphandlers/processorAppHandler.go 9.95% <ø> (+0.13%) ⬆️
app/apphandlers/setup.go 81.35% <ø> (+8.10%) ⬆️
backend-config/backend-config.go 84.95% <ø> (+3.21%) ⬆️
gateway/gateway.go 76.16% <ø> (-0.21%) ⬇️
jobsdb/admin.go 90.81% <ø> (+21.82%) ⬆️
jobsdb/jobsdb.go 73.88% <ø> (-0.04%) ⬇️
jobsdb/jobsdb_utils.go 92.56% <ø> (+13.79%) ⬆️
processor/processor.go 87.62% <ø> (+0.83%) ⬆️
... and 4 more

... and 9 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sidddddarth Sidddddarth marked this pull request as ready for review April 5, 2023 15:00
@atzoum
Copy link
Contributor

atzoum commented Apr 5, 2023

do we need any adaptations in rudder cli as well?

@Sidddddarth
Copy link
Member Author

do we need any adaptations in rudder cli as well?

we do, in progress.

@Sidddddarth
Copy link
Member Author

if we want to discontinue with cli entirely, we could remove more things as well.
For now I've kept the functionality wrt logging(setting, getting log level).

@atzoum
Copy link
Contributor

atzoum commented Apr 6, 2023

if we want to discontinue with cli entirely, we could remove more things as well. For now I've kept the functionality wrt logging(setting, getting log level).

Is this what we are removing support for?
https://github.com/rudderlabs/rudder-cli/blob/e6fb53b728a253a44fafcbacafd2e0ebaa28b2ac/main.go#L69

@Sidddddarth
Copy link
Member Author

Sidddddarth commented Apr 6, 2023

if we want to discontinue with cli entirely, we could remove more things as well. For now I've kept the functionality wrt logging(setting, getting log level).

Is this what we are removing support for? https://github.com/rudderlabs/rudder-cli/blob/e6fb53b728a253a44fafcbacafd2e0ebaa28b2ac/main.go#L69

Yes. Not only that but everything except logging and warehouse for now.

There are some warehouse related functionalities(trigger-upload and a few other). If the cli isn't used for it, we could entirely remove it. @lvrach

@Sidddddarth
Copy link
Member Author

In conclusion, kept the below functionalities intact:

  1. Admin.ServerConfig
  2. Admin.GetFormattedEnv
  3. Admin.SetLogLevel
  4. Admin.GetLoggingConfig
  5. Warehouse.TriggerUpload
  6. Warehouse.Query
  7. Warehouse.ConfigurationTest

We can remove more of these if they're unused or out of favour.

rudder-cli PR

@atzoum
Copy link
Contributor

atzoum commented Apr 6, 2023

Anyone who is using rudder-cli to comment here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants