Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bing ads bulk upload #3371

Merged
merged 142 commits into from
Aug 9, 2023
Merged

feat: bing ads bulk upload #3371

Show file tree
Hide file tree
Changes from 109 commits
Commits
Show all changes
142 commits
Select commit Hold shift + click to select a range
1ccd2a8
feat.bing ads first commit
May 17, 2023
0de9c0a
feat : interface flow for bingAds primary flow
shrouti1507 May 22, 2023
53e125b
feat: adding marketo via interface
shrouti1507 May 23, 2023
ccf5152
fix: deleting type.go
shrouti1507 May 23, 2023
510f770
fix: cleaning up the code
shrouti1507 May 23, 2023
a2163c2
Merge branch 'master' into feat.bing-ads
shrouti1507 May 24, 2023
d2622dd
fix: adding with decided interface
shrouti1507 May 24, 2023
2727673
fix: addressing primary review comments
shrouti1507 May 25, 2023
866b0a7
fix: addressing code reviews
shrouti1507 May 25, 2023
f223ce3
fix: poll function update
shrouti1507 May 26, 2023
6961bfb
initial commit with bingAds
ItsSudip May 29, 2023
fbb852c
implement fatchFailedEvents function placeholder
ItsSudip May 30, 2023
3bcbd34
feat(brt): onboarding bing ads audience bulk upload poll function (#3…
shrouti1507 Jun 8, 2023
fbe5deb
Apply suggestions from code review
shrouti1507 Jun 8, 2023
26cc128
Update router/batchrouter/asyncdestinationmanager/bing-ads/bingads.go
shrouti1507 Jun 8, 2023
9131525
Update router/batchrouter/asyncdestinationmanager/bing-ads/bingads.go
shrouti1507 Jun 8, 2023
95734cc
Update router/batchrouter/asyncdestinationmanager/bing-ads/bingads.go
shrouti1507 Jun 8, 2023
6649ec6
Update router/batchrouter/asyncdestinationmanager/bing-ads/bingads.go
shrouti1507 Jun 8, 2023
2b40ae6
fix: review comment addressed
shrouti1507 Jun 8, 2023
762342f
remove magic number and use constant
ItsSudip Jun 12, 2023
bb21fcb
Apply suggestions from code review
shrouti1507 Jun 12, 2023
7635f36
chore: refactors, and test cases added from chore.bingads
ItsSudip Jun 12, 2023
2eac21f
refer bingads sdk from other repo
ItsSudip Jun 13, 2023
d4e39a8
fix: retrieveImportantKey is deleted for bingads bulk upload and used…
shrouti1507 Jun 13, 2023
9ad179e
fix: changing variable names to more readble ones
shrouti1507 Jun 13, 2023
6816bd3
Merge branch 'master' into feat.bing-ads
shrouti1507 Jun 13, 2023
678dc60
Merge branch 'master' into feat.bing-ads
ItsSudip Jun 14, 2023
9ae8025
fix: adding interface for util function and mocking test cases
shrouti1507 Jun 14, 2023
400da9e
Merge branch 'feat.bing-ads' of github.com:rudderlabs/rudder-server i…
shrouti1507 Jun 14, 2023
33ecbef
Merge branch 'master' into feat.bing-ads
shrouti1507 Jun 14, 2023
6433753
fix go.mod
ItsSudip Jun 14, 2023
311437d
fix: bingads unit test file location change and minor refactors
shrouti1507 Jun 14, 2023
50db7f8
Merge branch 'feat.bing-ads' of github.com:rudderlabs/rudder-server i…
shrouti1507 Jun 14, 2023
5ebda6a
update failedreason for bingads
ItsSudip Jun 14, 2023
927e6c2
Merge branch 'master' into feat.bing-ads
shrouti1507 Jun 16, 2023
797d80c
fix: removing unnecessary files
shrouti1507 Jun 16, 2023
a7a3848
fix: removed mock for util functions and parsed the code (#3512)
shrouti1507 Jun 16, 2023
58d2755
fix: uncomment the required code for uploadInterval
shrouti1507 Jun 18, 2023
afa31ba
fix: making temp files in test cases through env var
shrouti1507 Jun 19, 2023
c24dc5a
fix: upadating the batch router test case by sending destination obje…
shrouti1507 Jun 19, 2023
13c4eed
Merge branch 'master' into feat.bing-ads
shrouti1507 Jun 19, 2023
45a238c
fix: fixing go.mod file, removing panic and adding test case
shrouti1507 Jun 20, 2023
b9def18
Merge branch 'feat.bing-ads' of github.com:rudderlabs/rudder-server i…
shrouti1507 Jun 20, 2023
bfdd6de
chore: bing ads tests
Jun 20, 2023
9844af1
fix: adding stats for bingads upload and upload status
shrouti1507 Jun 21, 2023
aab4746
fix: omit panics for marketo
shrouti1507 Jun 21, 2023
a4a0e63
fix: stats type
shrouti1507 Jun 21, 2023
749e5ac
Merge branch 'master' into feat.bing-ads
shrouti1507 Jun 21, 2023
2026eae
chore: altering upload freq for QA
shrouti1507 Jun 22, 2023
e352480
fix: fix potential bug and add clientID logic
shrouti1507 Jun 22, 2023
4e434a1
Merge branch 'master' into feat.bing-ads
shrouti1507 Jun 22, 2023
fe2c28f
fix: lint error fix
shrouti1507 Jun 23, 2023
2794e37
fix: lint error fix
shrouti1507 Jun 23, 2023
1c1df5c
fix: tidying up go.mod
shrouti1507 Jun 23, 2023
cb4182d
Merge branch 'master' into feat.bing-ads
shrouti1507 Jun 23, 2023
1df7c9d
fix: tidying up go.mod
shrouti1507 Jun 23, 2023
9a1ded7
feat: bingads audience adding support for multiple action polling and…
shrouti1507 Jun 30, 2023
953f51b
Merge branch 'master' into feat.bing-ads
shrouti1507 Jun 30, 2023
52874e6
refactor: run go mod tidy
koladilip Jul 1, 2023
4ec926f
refactor: bingads uploader into multiple files
koladilip Jul 2, 2023
7a9e9cc
feat: bingads destination config refresh (#3577)
ItsSudip Jul 3, 2023
98a3923
refactor: bingads implementation (#3573)
koladilip Jul 6, 2023
ecd5ccd
Merge branch 'master' into feat.bing-ads
koladilip Jul 6, 2023
ab31904
fix: addressing some lint issues
shrouti1507 Jul 6, 2023
a9808e5
fix: action file processing for event count zero
shrouti1507 Jul 6, 2023
11ae9cc
fix: status count via loop
shrouti1507 Jul 6, 2023
4ecd1ed
fix: adding debug log
shrouti1507 Jul 7, 2023
e643dc4
fix: linting issues
koladilip Jul 7, 2023
5a6faf5
Fix: TestRouterManager
koladilip Jul 7, 2023
93b0410
Merge branch 'master' into feat.bing-ads
koladilip Jul 7, 2023
0a9a6a0
Merge branch 'master' into feat.bing-ads
shrouti1507 Jul 10, 2023
ec309e2
fix: addressing comments regarding bingads
shrouti1507 Jul 11, 2023
78d1df5
fix: addressing comments regarding marketo
shrouti1507 Jul 11, 2023
51f5c33
add log on error
ItsSudip Jul 11, 2023
147d444
add statuscode in log
ItsSudip Jul 11, 2023
366baf4
fix: Adding stat for non initializing destination
shrouti1507 Jul 11, 2023
168e7d7
Merge branch 'feat.bing-ads' of github.com:rudderlabs/rudder-server i…
shrouti1507 Jul 11, 2023
260298d
Merge branch 'master' into feat.bing-ads
shrouti1507 Jul 11, 2023
46bd8f4
fix initializtion of logger
ItsSudip Jul 11, 2023
5d2c668
refactor: AsyncDestinationStruct
koladilip Jul 12, 2023
268b112
fix: small fix in refresh dest
shrouti1507 Jul 12, 2023
aeac098
Merge branch 'master' into feat.bing-ads
shrouti1507 Jul 12, 2023
c011c47
refactor: initAsyncDestinationStruct
koladilip Jul 12, 2023
d1ced4f
refactor: initAsyncDestinationStruct
koladilip Jul 12, 2023
1b6175c
refactor: handle_lifecycle setup
koladilip Jul 12, 2023
be1dd0c
fix: edit for testing
shrouti1507 Jul 12, 2023
6f4e8ec
Apply suggestions from code review
shrouti1507 Jul 17, 2023
d3b084e
refactor: batch router handle async and review comments address (#3623)
koladilip Jul 18, 2023
0432161
Merge branch 'master' into feat.bing-ads
shrouti1507 Jul 18, 2023
3fdb073
Merge branch 'master' into feat.bing-ads
shrouti1507 Jul 18, 2023
791ccca
fix: putting upload timeout to 30 mins
shrouti1507 Jul 18, 2023
c89e0ba
Update router/batchrouter/handle_async.go
koladilip Jul 19, 2023
4e127d1
Update router/batchrouter/handle_async.go
koladilip Jul 19, 2023
ebf092b
Update router/batchrouter/handle_async.go
koladilip Jul 19, 2023
6135e74
Update router/batchrouter/handle_async.go
koladilip Jul 19, 2023
0c892ef
fix: review comments addressed
shrouti1507 Jul 20, 2023
2656f33
chore: comments addressed
Jul 21, 2023
e45ac05
chore: comments addressed
Jul 21, 2023
bf29943
chore: comments addressed
Jul 21, 2023
f614269
Apply suggestions from code review part 1
shrouti1507 Jul 21, 2023
046665a
fix: bingAds related new review comments
shrouti1507 Jul 21, 2023
7c20eed
fix: apply suggestions for marketo bulk upload from code review
shrouti1507 Jul 21, 2023
b82a799
Apply suggestions for marketo from code review part 2
shrouti1507 Jul 21, 2023
437047f
fix: editing some import problem
shrouti1507 Jul 21, 2023
1f54a8d
Merge branch 'master' into feat.bing-ads
shrouti1507 Jul 21, 2023
16464a0
fix: lint error
shrouti1507 Jul 21, 2023
48e8975
fix: pollAsyncStatus to handle error cases
koladilip Jul 21, 2023
a31b86b
rename test files dir
koladilip Jul 21, 2023
9429b14
fix: move function to type.go
shrouti1507 Jul 21, 2023
369e8cb
Apply suggestions from code review
shrouti1507 Jul 24, 2023
b0f1010
Apply name suggestions from code review
shrouti1507 Jul 24, 2023
cdbdfd2
Apply suggestions from code review part 3
shrouti1507 Jul 24, 2023
ad07103
Apply name suggestions from code review part 3
shrouti1507 Jul 24, 2023
972d68c
Merge branch 'master' into feat.bing-ads
shrouti1507 Jul 24, 2023
53fc91c
fix: code error edits
shrouti1507 Jul 24, 2023
dde5546
Merge branch 'master' into feat.bing-ads
shrouti1507 Jul 24, 2023
39c303e
fix: review comment for marshal unmarshal addressed
shrouti1507 Jul 24, 2023
b08d664
fix: actionFile template making review
shrouti1507 Jul 24, 2023
ab7f4e2
fix: code error solve
shrouti1507 Jul 24, 2023
cda8f1b
Merge branch 'master' into feat.bing-ads
shrouti1507 Jul 25, 2023
2b8e67b
remove empty string check
ItsSudip Jul 25, 2023
056ce7a
Merge branch 'master' into feat.bing-ads
shrouti1507 Jul 26, 2023
d19a36f
fix: bingAds SDK version change
shrouti1507 Jul 26, 2023
28a7838
refactor: handle async
koladilip Jul 26, 2023
5342e8e
chore: fix lint issues
cisse21 Jul 27, 2023
26431d4
fix: marketo bulk upload poll function (#3684)
shrouti1507 Jul 31, 2023
dcbd07a
Merge branch 'master' into feat.bing-ads
koladilip Jul 31, 2023
f610238
Update router/batchrouter/asyncdestinationmanager/bing-ads/bulk_uploa…
shrouti1507 Aug 1, 2023
b66c133
fix: review comments addressed
shrouti1507 Aug 1, 2023
8843c4d
fix: remove unnecessary code
shrouti1507 Aug 1, 2023
d2691e4
Merge branch 'master' into feat.bing-ads
shrouti1507 Aug 1, 2023
7aa9b60
fix: batch router attemptnos (#3696)
chandumlg Aug 3, 2023
48c9ea4
Merge branch 'master' into feat.bing-ads
shrouti1507 Aug 3, 2023
cde5e61
update buffer size of scanner
ItsSudip Aug 4, 2023
a63b45e
update buffer size of scanner to 50mb
ItsSudip Aug 4, 2023
1432910
Merge branch 'master' into feat.bing-ads
shrouti1507 Aug 7, 2023
a73f0d8
fix: batch router attemptnos, reports, rsources stats (#3698)
chandumlg Aug 8, 2023
fed443c
chore: lint fixes
Aug 8, 2023
d152c8e
Merge branch 'master' into feat.bing-ads
chandumlg Aug 9, 2023
5a4b90c
chore: live events
Aug 9, 2023
a7ea75a
chore: max file size
Aug 9, 2023
fac75e2
Merge branch 'master' into feat.bing-ads
shrouti1507 Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,7 @@ require (
github.com/rivo/uniseg v0.1.0 // indirect
github.com/rs/xid v1.5.0 // indirect
github.com/rs/zerolog v1.28.0 // indirect
github.com/rudderlabs/bing-ads-go-sdk v0.1.0
github.com/russross/blackfriday/v2 v2.1.0 // indirect
github.com/segmentio/backo-go v1.0.1 // indirect
github.com/shirou/gopsutil/v3 v3.23.4 // indirect
Expand Down
2 changes: 2 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1740,6 +1740,8 @@ github.com/rs/zerolog v1.28.0 h1:MirSo27VyNi7RJYP3078AA1+Cyzd2GB66qy3aUHvsWY=
github.com/rs/zerolog v1.28.0/go.mod h1:NILgTygv/Uej1ra5XxGf82ZFSLk58MFGAUS2o6usyD0=
github.com/rudderlabs/analytics-go v3.3.3+incompatible h1:OG0XlKoXfr539e2t1dXtTB+Gr89uFW+OUNQBVhHIIBY=
github.com/rudderlabs/analytics-go v3.3.3+incompatible/go.mod h1:LF8/ty9kUX4PTY3l5c97K3nZZaX5Hwsvt+NBaRL/f30=
github.com/rudderlabs/bing-ads-go-sdk v0.1.0 h1:+uWzOuiUEG72pwcoSQoKL7b34s6GCliRKR9TXbn7mCI=
github.com/rudderlabs/bing-ads-go-sdk v0.1.0/go.mod h1:n718Q+g1OBGi7rOIRLvKU+1Ep0gwkEOdQzMdwvzpCXU=
github.com/rudderlabs/compose-test v0.1.2 h1:GTt8meEXkdOXPZWKW0r5mDRA5ddachR/pR+xsrWNU54=
github.com/rudderlabs/compose-test v0.1.2/go.mod h1:J1UaMZXoXRGHE0+VLpHZ/0hp+1F2m5cmjOKcwaN5LOU=
github.com/rudderlabs/parquet-go v0.0.2 h1:ZXRdZdimB0PdJtmxeSSxfI0fDQ3kZjwzBxRi6Ut1J8k=
Expand Down
80 changes: 80 additions & 0 deletions mocks/router/bingads/mock_bulkservice.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

296 changes: 0 additions & 296 deletions router/batchrouter/asyncdestinationmanager/asyncdestinationmanager.go
View file
Open in desktop

This file was deleted.

Loading
Loading