Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gw transient errors crash #3397

Merged
merged 15 commits into from
Jun 8, 2023
Merged

fix: gw transient errors crash #3397

merged 15 commits into from
Jun 8, 2023

Conversation

saurav-malani
Copy link
Contributor

@saurav-malani saurav-malani commented May 25, 2023

Description

PR modifies maintenance loop in jobsdb to make handling of transient errors configurable.

Notion Ticket

https://www.notion.so/rudderstacks/Gateway-shall-not-panic-on-transient-DNS-errors-ff53bcb47f6045b1a409aecea927841c?pvs=4

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@saurav-malani saurav-malani changed the title Fix.gw transient errors fix: gw transient errors May 25, 2023
@saurav-malani saurav-malani changed the title fix: gw transient errors Fix: gw transient errors May 25, 2023
@saurav-malani saurav-malani changed the title Fix: gw transient errors fix: gw transient errors May 25, 2023
@saurav-malani saurav-malani changed the title fix: gw transient errors fix: gw transient errors crash May 25, 2023
app/apphandlers/embeddedAppHandler.go Outdated Show resolved Hide resolved
jobsdb/jobsdb.go Outdated Show resolved Hide resolved
jobsdb/jobsdb.go Outdated Show resolved Hide resolved
jobsdb/jobsdb.go Outdated Show resolved Hide resolved
jobsdb/jobsdb.go Outdated Show resolved Hide resolved
jobsdb/migration.go Outdated Show resolved Hide resolved
jobsdb/migration.go Outdated Show resolved Hide resolved
jobsdb/migration.go Outdated Show resolved Hide resolved
jobsdb/migration.go Outdated Show resolved Hide resolved
jobsdb/migration.go Outdated Show resolved Hide resolved
jobsdb/jobsdb.go Outdated Show resolved Hide resolved
jobsdb/jobsdb.go Outdated Show resolved Hide resolved
jobsdb/jobsdb.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch coverage: 43.10% and project coverage change: -0.16 ⚠️

Comparison is base (9e32802) 68.47% compared to head (6c099cf) 68.31%.

❗ Current head 6c099cf differs from pull request most recent head 3eda7a8. Consider uploading reports for the commit 3eda7a8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3397      +/-   ##
==========================================
- Coverage   68.47%   68.31%   -0.16%     
==========================================
  Files         330      330              
  Lines       53042    53114      +72     
==========================================
- Hits        36319    36284      -35     
- Misses      14358    14433      +75     
- Partials     2365     2397      +32     
Impacted Files Coverage Δ
app/apphandlers/gatewayAppHandler.go 14.28% <0.00%> (-0.33%) ⬇️
app/apphandlers/processorAppHandler.go 9.05% <0.00%> (-0.20%) ⬇️
jobsdb/unionQuery.go 88.03% <ø> (ø)
jobsdb/backup.go 70.39% <31.03%> (-4.65%) ⬇️
jobsdb/migration.go 70.31% <33.33%> (-5.61%) ⬇️
router/batchrouter/handle.go 62.91% <33.33%> (-0.28%) ⬇️
jobsdb/jobsdb_utils.go 89.28% <50.00%> (-3.09%) ⬇️
jobsdb/jobsdb.go 72.50% <55.11%> (-1.47%) ⬇️
app/apphandlers/embeddedAppHandler.go 77.69% <100.00%> (+0.42%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@atzoum atzoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting to review changes after rebasing lint fixes introduced in master

Copy link
Contributor

@atzoum atzoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting to review changes after rebasing lint fixes introduced in master

jobsdb/backup.go Outdated Show resolved Hide resolved
jobsdb/backup.go Outdated Show resolved Hide resolved
jobsdb/backup.go Outdated Show resolved Hide resolved
jobsdb/backup.go Outdated Show resolved Hide resolved
jobsdb/backup.go Outdated Show resolved Hide resolved
jobsdb/backup.go Outdated Show resolved Hide resolved
jobsdb/backup.go Outdated Show resolved Hide resolved
saurav-malani and others added 2 commits June 6, 2023 16:30
Co-authored-by: Leonidas Vrachnis <leo.al.vra@gmail.com>
@saurav-malani saurav-malani requested a review from lvrach June 6, 2023 11:06
jobsdb/backup.go Outdated Show resolved Hide resolved
jobsdb/migration.go Outdated Show resolved Hide resolved
Co-authored-by: Aris Tzoumas <atzoumas@rudderstack.com>
@saurav-malani saurav-malani requested a review from atzoum June 7, 2023 12:53
@saurav-malani saurav-malani merged commit 6ad51e8 into master Jun 8, 2023
28 checks passed
@saurav-malani saurav-malani deleted the fix.GWTransientErrors branch June 8, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants