Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop failing backups after few retries #3695

Merged
merged 3 commits into from
Aug 3, 2023
Merged

Conversation

cisse21
Copy link
Member

@cisse21 cisse21 commented Aug 2, 2023

Description

Drop backups after a fixed number of retries

Linear Ticket

Linear Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@cisse21 cisse21 changed the title fix : drop failing backups after few retries chore : drop failing backups after few retries Aug 2, 2023
@cisse21 cisse21 changed the title chore : drop failing backups after few retries chore: drop failing backups after few retries Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 58.62% and project coverage change: +0.03% 🎉

Comparison is base (3cca234) 68.05% compared to head (755bb4b) 68.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3695      +/-   ##
==========================================
+ Coverage   68.05%   68.08%   +0.03%     
==========================================
  Files         319      319              
  Lines       50456    50463       +7     
==========================================
+ Hits        34339    34359      +20     
+ Misses      13890    13876      -14     
- Partials     2227     2228       +1     
Files Changed Coverage Δ
jobsdb/backup.go 69.25% <58.62%> (-0.66%) ⬇️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sidddddarth
Copy link
Member

Can use ctx in getRowCounts and createTableDumps.

@cisse21 cisse21 merged commit c81c66f into master Aug 3, 2023
35 checks passed
@cisse21 cisse21 deleted the fix.dropFailingBackups branch August 3, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants