Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: introduce encoding factory #3740

Merged
merged 6 commits into from
Aug 21, 2023

chore: review comments

e5c4032
Select commit
Loading
Failed to load commit list.
Merged

chore: introduce encoding factory #3740

chore: review comments
e5c4032
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Aug 18, 2023 in 1s

86.99% of diff hit (target 68.78%)

View this Pull Request on Codecov

86.99% of diff hit (target 68.78%)

Annotations

Check warning on line 38 in warehouse/encoding/jsonreader.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

warehouse/encoding/jsonreader.go#L37-L38

Added lines #L37 - L38 were not covered by tests

Check warning on line 48 in warehouse/encoding/parquetloader.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

warehouse/encoding/parquetloader.go#L48

Added line #L48 was not covered by tests

Check warning on line 228 in warehouse/upload.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

warehouse/upload.go#L228

Added line #L228 was not covered by tests

Check warning on line 233 in warehouse/upload.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

warehouse/upload.go#L233

Added line #L233 was not covered by tests

Check warning on line 238 in warehouse/upload.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

warehouse/upload.go#L238

Added line #L238 was not covered by tests

Check warning on line 243 in warehouse/upload.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

warehouse/upload.go#L243

Added line #L243 was not covered by tests

Check warning on line 248 in warehouse/upload.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

warehouse/upload.go#L248

Added line #L248 was not covered by tests

Check warning on line 292 in warehouse/upload.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

warehouse/upload.go#L291-L292

Added lines #L291 - L292 were not covered by tests

Check warning on line 294 in warehouse/upload.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

warehouse/upload.go#L294

Added line #L294 was not covered by tests

Check warning on line 401 in warehouse/upload.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

warehouse/upload.go#L401

Added line #L401 was not covered by tests

Check warning on line 822 in warehouse/upload.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

warehouse/upload.go#L822

Added line #L822 was not covered by tests

Check warning on line 842 in warehouse/upload.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

warehouse/upload.go#L842

Added line #L842 was not covered by tests

Check warning on line 1109 in warehouse/upload.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

warehouse/upload.go#L1109

Added line #L1109 was not covered by tests

Check warning on line 1138 in warehouse/upload.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

warehouse/upload.go#L1138

Added line #L1138 was not covered by tests

Check warning on line 1311 in warehouse/upload.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

warehouse/upload.go#L1311

Added line #L1311 was not covered by tests

Check warning on line 1423 in warehouse/upload.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

warehouse/upload.go#L1423

Added line #L1423 was not covered by tests

Check warning on line 2023 in warehouse/upload.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

warehouse/upload.go#L2023

Added line #L2023 was not covered by tests

Check warning on line 67 in warehouse/upload_stats.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

warehouse/upload_stats.go#L67

Added line #L67 was not covered by tests

Check warning on line 83 in warehouse/upload_stats.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

warehouse/upload_stats.go#L83

Added line #L83 was not covered by tests

Check warning on line 111 in warehouse/upload_stats.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

warehouse/upload_stats.go#L111

Added line #L111 was not covered by tests

Check warning on line 127 in warehouse/upload_stats.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

warehouse/upload_stats.go#L127

Added line #L127 was not covered by tests

Check warning on line 168 in warehouse/upload_stats.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

warehouse/upload_stats.go#L168

Added line #L168 was not covered by tests

Check warning on line 194 in warehouse/upload_stats.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

warehouse/upload_stats.go#L194

Added line #L194 was not covered by tests