-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support HSET
in redis
#3768
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
9d696e3
feat: support hset in redis
debanjan97 abd20ac
chore: handles hash field updates in a separate function
debanjan97 4807867
chore: renames vars
debanjan97 7ea0bec
Merge branch 'master' of github.com:rudderlabs/rudder-server into PRO…
debanjan97 bd3e3d3
Merge branch 'master' into PRO-633
debanjan97 87bc649
chore: renames vars
debanjan97 a53e4d1
Merge branch 'PRO-633' of github.com:rudderlabs/rudder-server into PR…
debanjan97 d4a8bb1
fix: update HSET criteria
debanjan97 cbde9a8
fix: update HSET criteria 2
debanjan97 6773e1f
adds test
debanjan97 00c4a95
mocks
debanjan97 44f4b17
code smells
debanjan97 194682d
Merge branch 'master' into PRO-633
debanjan97 08ddb4e
adds comments | renames variables+functions
debanjan97 9c98d8f
chore: rename vars
debanjan97 f52188c
chore: reuse vars for `IsHSETCompatibleEvent`
debanjan97 d6e5ae6
change from var to const
debanjan97 9b8191c
Merge branch 'master' of github.com:rudderlabs/rudder-server into PRO…
debanjan97 189e91a
chore: optimise tests
debanjan97 9a9cf61
Merge branch 'master' into PRO-633
debanjan97 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would avoid the extensive and repeated usage of
gjson.
Using a go struct
It would be safer and faster (assuming fastjson library is used)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if I understand
faster (assuming fastjson library is used)
completely.I can use fastjson's Exists but that doesn't require a go struct to unmarshal to.
Unless we somehow use fastjson while unmarshalling, using CustomUnmarshal, or I might be completely missing the point here.