Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: apk usage in Dockerfile #3835

Merged
merged 1 commit into from Nov 3, 2023
Merged

Conversation

PeterDaveHello
Copy link
Contributor

Less commands, faster build, and smaller image!

@github-actions
Copy link

This PR is considered to be stale. It has been open 20 days with no further activity thus it is going to be closed in 5 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

@github-actions github-actions bot added the Stale label Sep 27, 2023
@PeterDaveHello
Copy link
Contributor Author

@achettyiitr anything I can do 😅 ?

@github-actions github-actions bot removed the Stale label Sep 28, 2023
Copy link
Member

@achettyiitr achettyiitr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason, we are skipping the update here?

@achettyiitr achettyiitr self-requested a review September 28, 2023 11:56
Dockerfile Show resolved Hide resolved
@PeterDaveHello
Copy link
Contributor Author

@achettyiitr @atzoum just FYR, it's kind of Dockerfile best practices:

https://github.com/hadolint/hadolint/wiki/DL3019

@github-actions
Copy link

This PR is considered to be stale. It has been open 20 days with no further activity thus it is going to be closed in 5 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

@github-actions github-actions bot added the Stale label Oct 22, 2023
@PeterDaveHello
Copy link
Contributor Author

Not sure if there's anything I can do here?

@github-actions github-actions bot removed the Stale label Oct 23, 2023
@atzoum
Copy link
Contributor

atzoum commented Oct 31, 2023

@atzoum atzoum changed the title Refactor apk usage in Dockerfile refactor: apk usage in Dockerfile Oct 31, 2023
@atzoum atzoum changed the title refactor: apk usage in Dockerfile refactor: apk usage in Dockerfile Oct 31, 2023
@PeterDaveHello
Copy link
Contributor Author

It's done now!

@lvrach lvrach merged commit a1b22c6 into rudderlabs:master Nov 3, 2023
53 of 71 checks passed
@lvrach
Copy link
Member

lvrach commented Nov 3, 2023

Thanks @PeterDaveHello for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants